Sun Condition Statement Should Be a Popup to Avoid Confusion

[Farranco]

Checklist

• I have updated to the latest available Home Assistant version.
• I have cleared the cache of my browser.
• I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

The interface for automation on the sun condition is confusion. It allows for both sunrise and sunset to be selected. This results on a condition that is always false. A lot of users are going to look for "at night" or "during the day", although it would be good to add those as popup values as well, at a minimum it should be a popup for: "After" or "Before". With a subsequent selection for "Sunrise" or "Sunset". As it stands it easy to select both and not realize that you need an "Or" condition and only select one value. It's easy to end up with then following incorrect YAML:

condition: sun
before: sunrise
after: sunset  

When what users are looking for is:

condition: or
conditions:
  - condition: sun
    after: sunset
  - condition: sun
    before: sunrise

Describe the behavior you expected

If selecting before, disable after and vice versa or make it a popup allowing a single choice.

Steps to reproduce the issue

1. Create a new condition on an automation.
2. Select "Sun"
3. Check both before and after.

What version of Home Assistant Core has the issue?

core-2021.4.5

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Safari 14.0.13

Which operating system are you using to run this browser?

MacOS 11.1

State of relevant entities

# Paste your state here.

Problem-relevant frontend configuration

# Paste your YAML here.

Javascript errors shown in your browser console/inspector

# Paste your logs here.