Skip to content

Commit b3bcf5f

Browse files
authored
Fix share server button crash on iPad due to wrong sourceView (#3667)
<!-- Thank you for submitting a Pull Request and helping to improve Home Assistant. Please complete the following sections to help the processing and review of your changes. Please do not delete anything from this template. --> ## Summary <!-- Provide a brief summary of the changes you have made and most importantly what they aim to achieve --> ## Screenshots <!-- If this is a user-facing change not in the frontend, please include screenshots in light and dark mode. --> ## Link to pull request in Documentation repository <!-- Pull requests that add, change or remove functionality must have a corresponding pull request in the Companion App Documentation repository (https://github.com/home-assistant/companion.home-assistant). Please add the number of this pull request after the "#" --> Documentation: home-assistant/companion.home-assistant# ## Any other notes <!-- If there is any other information of note, like if this Pull Request is part of a bigger change, please include it here. -->
1 parent 88468d0 commit b3bcf5f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

Sources/App/Settings/Connection/ConnectionSettingsViewController.swift

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -312,13 +312,14 @@ class ConnectionSettingsViewController: HAFormViewController, RowControllerType
312312

313313
let activityVC = UIActivityViewController(activityItems: [invitationURL], applicationActivities: nil)
314314
if let popover = activityVC.popoverPresentationController {
315-
popover.sourceView = shareButton.customView
316-
popover.sourceRect = shareButton.customView?.bounds ?? CGRect(
317-
x: view.bounds.width - 1,
318-
y: 0,
319-
width: 1,
320-
height: 1
315+
popover.sourceView = view
316+
popover.sourceRect = CGRect(
317+
x: view.bounds.midX,
318+
y: view.bounds.midY,
319+
width: 0,
320+
height: 0
321321
)
322+
popover.permittedArrowDirections = []
322323
}
323324
present(activityVC, animated: true, completion: nil)
324325
}

0 commit comments

Comments
 (0)