Skip to content

Commit 487a068

Browse files
committed
Update changelog and fix MunkiAdmin script name checking
1 parent a685087 commit 487a068

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,13 @@ All notable changes to this project will be documented in this file. This projec
1212

1313
## [Unreleased]
1414

15+
Nothing yet.
16+
17+
## [1.19.0] - 2025-01-16
18+
1519
### Added
1620

21+
- Added `--warn-on-missing-installer-items` flag that makes missing Munki install/uninstall items a warning instead of a failure. (#86, thanks to @haircut)
1722
- `check-autopkg-recipes` requires Munki recipe `pkginfo` dicts to contain at least `name` and `description`.
1823
- `check-autopkg-recipes` now validates that `uninstall_method` and `uninstall_script` are set appropriately in Munki recipes.
1924

@@ -22,6 +27,10 @@ All notable changes to this project will be documented in this file. This projec
2227
- `check-autopkg-recipes` includes jamf-upload as an AutoPkg recipe type, and updated processors included in jamf/jamf-upload recipe convention.
2328
- `check-munki-pkgsinfo` requires a `version` key in addition to `name` and `description`.
2429

30+
### Fixed
31+
32+
- Bug fix in `check-munkiadmin-scripts` that prevented script names from processing correctly.
33+
2534
## [1.18.0] - 2025-01-04
2635

2736
### Added

pre_commit_hooks/check_munkiadmin_scripts.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ def main(argv=None):
3232
prefixes = ["manifest", "pkginfo", "repository"]
3333
actions = ["custom", "postopen", "postsave", "presave"]
3434
ma_script_prefixes = [f"{p}-{a}" for p in prefixes for a in actions]
35-
if not any(filename.startswith(prefix) for prefix in ma_script_prefixes):
35+
if not any(
36+
os.path.basename(filename).startswith(prefix)
37+
for prefix in ma_script_prefixes
38+
):
3639
print(f"{filename}: does not start with a valid MunkiAdmin script prefix")
3740
retval = 1
3841

0 commit comments

Comments
 (0)