Check for deprecated installer_type and uninstall_method values

Author: homebysix

CHANGELOG.md

@@ -16,6 +16,7 @@ All notable changes to this project will be documented in this file. This projec
 
 - `check-autopkg-recipes` and `check-munki-pkgsinfo` now validates that `supported_architectures` values are set appropriately.
 - In anticipation of Munki 7, `check-munki-pkgsinfo` validates that `version_script` is a string starting with a script shebang.
+- `check-munki-pkgsinfo` now checks for specific deprecated `installer_type` and `uninstall_method` values, most of which are detailed [here](https://github.com/munki/munki/wiki/Deprecation-Notes).
 
 ### Changed
 

pre_commit_hooks/check_munki_pkgsinfo.py

@@ -141,6 +141,36 @@ def main(argv=None):
         if not detect_typoed_keys(pkginfo, filename):
             retval = 1
 
+        # Check for deprecated installer_type values.
+        depr_installer_types = (
+            "AdobeAcrobatUpdater",
+            "AdobeCCPInstaller",
+            "AdobeCS5AAMEEPackage",
+            "AdobeCS5PatchInstaller",
+            "AdobeSetup",
+            "AdobeUberInstaller",
+            "appdmg",
+            "apple_update_metadata",
+            "profile",
+            "startosinstall",
+        )
+        if pkginfo.get("installer_type") in depr_installer_types:
+            print(
+                f"{filename}: WARNING: installer_type '{pkginfo.get('installer_type')}' is deprecated"
+            )
+
+        # Check for deprecated uninstall_method values.
+        depr_uninstall_methods = (
+            "AdobeCCPUninstaller",
+            "AdobeCS5AAMEEPackage",
+            "AdobeSetup",
+            "AdobeUberUninstaller",
+        )
+        if pkginfo.get("uninstall_method") in depr_uninstall_methods:
+            print(
+                f"{filename}: WARNING: uninstall_method '{pkginfo.get('uninstall_method')}' is deprecated"
+            )
+
         # Check for rogue categories.
         if args.categories and pkginfo.get("category") not in args.categories:
             print(