Check naming convention of MunkiAdmin scripts

Author: homebysix

.pre-commit-hooks.yaml

@@ -71,7 +71,7 @@
 
 - id: check-munkiadmin-scripts
   name: Check MunkiAdmin Scripts
-  description: This hook ensures MunkiAdmin scripts are executable.
+  description: This hook ensures MunkiAdmin scripts are named properly and executable.
   entry: check-munkiadmin-scripts
   language: python
   files: "^MunkiAdmin/scripts/"

CHANGELOG.md

@@ -15,6 +15,7 @@ All notable changes to this project will be documented in this file. This projec
 ### Added
 
 - `check-munki-pkgsinfo` now produces an error if `uninstall_method` is set to `uninstall_script` but no uninstall script is present in the pkginfo.
+- `check-munkiadmin-scripts` now checks whether scripts are named correctly, not just executable.
 
 ## [1.17.0] - 2024-12-22
 

pre_commit_hooks/check_munkiadmin_scripts.py

@@ -27,6 +27,15 @@ def main(argv=None):
     retval = 0
     for filename in args.filenames:
 
+        # Ensure scripts are named properly.
+        # https://github.com/hjuutilainen/munkiadmin/blob/4f4e96da1f1c7a4dfe7da59d88f1ef68ee02b8f2/MunkiAdmin/Singletons/MAMunkiRepositoryManager.m#L23
+        prefixes = ["manifest", "pkginfo", "repository"]
+        actions = ["custom", "postopen", "postsave", "presave"]
+        ma_script_prefixes = [f"{p}-{a}" for p in prefixes for a in actions]
+        if not any(filename.startswith(prefix) for prefix in ma_script_prefixes):
+            print(f"{filename}: does not start with a valid MunkiAdmin script prefix")
+            retval = 1
+
         # Ensure scripts are executable
         if not os.access(filename, os.X_OK):
             print(f"{filename}: not executable")