feat: persist socket_id in EventContext during LiveView mount (#681)

Author: joshuap

lib/honeybadger/insights/live_view.ex

@@ -61,6 +61,10 @@ defmodule Honeybadger.Insights.LiveView do
       Honeybadger.Utils.rand_id()
     end)
 
+    Honeybadger.EventContext.put_new(:socket_id, fn ->
+      extract_socket_id(metadata)
+    end)
+
     if event in get_insights_config(:telemetry_events, @telemetry_events) do
       handle_event_impl(event, measurements, metadata, opts)
     end

test/honeybadger/insights/live_view_test.exs

@@ -56,4 +56,83 @@ defmodule Honeybadger.Insights.LiveViewTest do
       assert event["assigns"] == nil
     end
   end
+
+  describe "mount start handler" do
+    test "sets socket_id in event context from socket" do
+      :telemetry.execute(
+        [:phoenix, :live_view, :mount, :start],
+        %{},
+        %{
+          socket: %{
+            id: "phx-Fmount123",
+            view: MyApp.DashboardLive,
+            assigns: %{}
+          }
+        }
+      )
+
+      assert Honeybadger.EventContext.get(:socket_id) == "phx-Fmount123"
+    end
+
+    test "sets socket_id in event context from socket_id key" do
+      :telemetry.execute(
+        [:phoenix, :live_view, :mount, :start],
+        %{},
+        %{
+          socket_id: "phx-Gtop456"
+        }
+      )
+
+      assert Honeybadger.EventContext.get(:socket_id) == "phx-Gtop456"
+    end
+
+    test "socket_id propagates to subsequent events" do
+      :telemetry.execute(
+        [:phoenix, :live_view, :mount, :start],
+        %{},
+        %{
+          socket: %{
+            id: "phx-Hprop789",
+            view: MyApp.DashboardLive,
+            assigns: %{}
+          }
+        }
+      )
+
+      event =
+        send_and_receive(
+          [:phoenix, :live_view, :handle_event, :stop],
+          %{duration: System.convert_time_unit(5, :microsecond, :native)},
+          %{
+            uri: "/dashboard",
+            socket: %{
+              id: "phx-Hprop789",
+              view: MyApp.DashboardLive,
+              assigns: %{}
+            },
+            event: "click"
+          }
+        )
+
+      assert event["socket_id"] == "phx-Hprop789"
+    end
+
+    test "does not overwrite existing socket_id in event context" do
+      Honeybadger.EventContext.merge(%{socket_id: "existing-id"})
+
+      :telemetry.execute(
+        [:phoenix, :live_view, :mount, :start],
+        %{},
+        %{
+          socket: %{
+            id: "phx-Inew999",
+            view: MyApp.DashboardLive,
+            assigns: %{}
+          }
+        }
+      )
+
+      assert Honeybadger.EventContext.get(:socket_id) == "existing-id"
+    end
+  end
 end