Skip to content
This repository was archived by the owner on Aug 13, 2025. It is now read-only.

Commit b0c0cef

Browse files
authored
main: use published BaggageSpanProcessor and remove internal one (#192)
## Which problem is this PR solving? Improve community support for the baggage span processor. ## Short description of the changes The baggage span processor is being upstreamed to the OpenTelemetry project, marking the one in this repository as deprecated. ## How to verify that this has the expected result Unit tests are still in place --------- Signed-off-by: Alex Boten <[email protected]>
1 parent 96f2112 commit b0c0cef

File tree

6 files changed

+23
-119
lines changed

6 files changed

+23
-119
lines changed

poetry.lock

Lines changed: 16 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ opentelemetry-api = "^1.22.0"
2424
opentelemetry-sdk = "^1.22.0"
2525
opentelemetry-exporter-otlp = "^1.22.0"
2626
opentelemetry-instrumentation = "^0.43b0"
27+
opentelemetry-processor-baggage = "~0.46b0"
2728

2829
[tool.poetry.group.dev.dependencies]
2930
coverage = ">=6.5,<8.0"

src/honeycomb/opentelemetry/baggage.py

Lines changed: 0 additions & 42 deletions
This file was deleted.

src/honeycomb/opentelemetry/trace.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@
1111
from opentelemetry.exporter.otlp.proto.http.trace_exporter import (
1212
OTLPSpanExporter as HTTPSpanExporter
1313
)
14+
from opentelemetry.processor.baggage import (
15+
ALLOW_ALL_BAGGAGE_KEYS,
16+
BaggageSpanProcessor
17+
)
1418
from honeycomb.opentelemetry.local_exporter import configure_local_exporter
1519
from honeycomb.opentelemetry.options import HoneycombOptions
1620
from honeycomb.opentelemetry.sampler import configure_sampler
17-
from honeycomb.opentelemetry.baggage import BaggageSpanProcessor
1821

1922

2023
def create_tracer_provider(
@@ -47,7 +50,7 @@ def create_tracer_provider(
4750
sampler=configure_sampler(options)
4851
)
4952
trace_provider.add_span_processor(
50-
BaggageSpanProcessor()
53+
BaggageSpanProcessor(ALLOW_ALL_BAGGAGE_KEYS)
5154
)
5255

5356
trace_provider.add_span_processor(

tests/test_baggage.py

Lines changed: 0 additions & 72 deletions
This file was deleted.

tests/test_trace.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from opentelemetry.exporter.otlp.proto.http.trace_exporter import (
1111
OTLPSpanExporter as HTTPSpanExporter
1212
)
13-
from honeycomb.opentelemetry.baggage import BaggageSpanProcessor
13+
from opentelemetry.processor.baggage import BaggageSpanProcessor
1414
from honeycomb.opentelemetry.local_exporter import LocalTraceLinkSpanExporter
1515
from honeycomb.opentelemetry.options import HoneycombOptions
1616
from honeycomb.opentelemetry.resource import create_resource
@@ -19,7 +19,6 @@
1919
"""
2020
Our Tracer Provider expects a series of span processors.
2121
22-
BaggageSpanProcessor (no export)
2322
BatchSpanProcessor (Honeycomb Exporter)
2423
SimpleSpanProcessor (Console Exporter)
2524
SimpleSpanProcessor (Local Vis Exporter)

0 commit comments

Comments
 (0)