Skip to content

Commit 86db215

Browse files
authored
[vscode-mlir] Added per-LSP-server executable arguments (llvm#79671)
Each LSP server type (mlir-lsp-server, pdll-lsp-server and tblgen-lsp-server) should have a different "additional_server_args" entry in the config for passing arguments to the server such as `--log=verbose`.
1 parent 15e1e3b commit 86db215

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

mlir/utils/vscode/package.json

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "vscode-mlir",
33
"displayName": "MLIR",
44
"description": "MLIR Language Extension",
5-
"version": "0.0.11",
5+
"version": "0.0.12",
66
"publisher": "llvm-vs-code-extensions",
77
"homepage": "https://mlir.llvm.org/",
88
"icon": "icon.png",
@@ -47,7 +47,7 @@
4747
"@types/vscode": "~1.67.0",
4848
"@vscode/vsce": "^2.19.0",
4949
"clang-format": "^1.8.0",
50-
"typescript": "^4.6.4",
50+
"typescript": "^4.9.5",
5151
"vscode-test": "^1.3.0"
5252
},
5353
"repository": {
@@ -155,6 +155,11 @@
155155
"type": "string",
156156
"description": "The file path of the mlir-lsp-server executable."
157157
},
158+
"mlir.mlir_additional_server_args": {
159+
"scope": "resource",
160+
"type": "array",
161+
"description": "A list of additional arguments for mlir-lsp-server executable. E.g. --log=verbose."
162+
},
158163
"mlir.pdll_server_path": {
159164
"scope": "resource",
160165
"type": "string",
@@ -165,6 +170,11 @@
165170
"type": "array",
166171
"description": "A list of `pdll_compile_commands.yml` database files containing information about .pdll files processed by the server."
167172
},
173+
"mlir.pdll_additional_server_args": {
174+
"scope": "resource",
175+
"type": "array",
176+
"description": "A list of additional arguments for pdll-lsp-server executable. E.g. --log=verbose."
177+
},
168178
"mlir.tablegen_server_path": {
169179
"scope": "resource",
170180
"type": "string",
@@ -175,6 +185,11 @@
175185
"type": "array",
176186
"description": "A list of `tablegen_compile_commands.yml` database files containing information about .td files processed by the server."
177187
},
188+
"mlir.tablegen_additional_server_args": {
189+
"scope": "resource",
190+
"type": "array",
191+
"description": "A list of additional arguments for tblgen-lsp-server executable. E.g. --log=verbose."
192+
},
178193
"mlir.onSettingsChanged": {
179194
"type": "string",
180195
"default": "prompt",

mlir/utils/vscode/src/mlirContext.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ export class MLIRContext implements vscode.Disposable {
176176
let configsToWatch: string[] = [];
177177
let filepathsToWatch: string[] = [];
178178
let additionalServerArgs: string[] = [];
179+
additionalServerArgs = config.get<string[]>(languageName + "_additional_server_args", null, []);
179180

180181
// Initialize additional configurations for this server.
181182
if (languageName === 'pdll') {

0 commit comments

Comments
 (0)