Client premature close (abort) not detected

[Tomas2D]

Detection of client's premature close has been fixed by #107, but lately broken again via ba26b94.

[usualoma]

Hi @Tomas2D
Thank you for creating the issue.

We are aware that the current node-server may not detect connection disconnections in some cases. However, as mentioned in #172, incoming.destroyed also becomes true for a normal POST request, so we are not using it in the node server.

It would be good if we could detect that the connection was really aborted, excluding the case of a normal POST request.

[Tomas2D]

Based on nodejs/node#46666 we could do this instead.

outgoing.on('close', () => {
  if (incoming.errored) {
    req[getAbortController]().abort(incoming.errored.toString())
   } else if (!outgoing.writableFinished) {
    req[getAbortController]().abort('Client connection prematurely closed.')
   }
})

[usualoma]

@Tomas2D Thanks for the reply!
I've confirmed that using outgoing.writableFinished does indeed give the expected result.

Could you please update #218 with this information? We would also appreciate it if you could add a test. If adding a test is difficult, we can handle it here.

[Tomas2D]

Great. PR has been updated. I updated tests also to cover non-GET HTTP requests.

[yusukebe]

@Tomas2D

Can we close this issue now?

[Tomas2D]

Sure. Thank you.