Canceling an aborted stream terminates the hono process

[KnisterPeter]

Hi there,

we have an issue with our application running on node.js using hono.
The error we see in our logs is this one:

AbortError: The operation was aborted
    at destroyer (node:internal/streams/destroy:328:11)
    at Object.cancel (node:internal/webstreams/adapters:500:7)
    at invokePromiseCallback (node:internal/webstreams/util:172:10)
    at Object.cancelAlgorithm (node:internal/webstreams/util:177:23)
    at readableStreamDefaultControllerCancelSteps (node:internal/webstreams/readablestream:2414:37)
    at [kCancel] (node:internal/webstreams/readablestream:1089:12)
    at readableStreamCancel (node:internal/webstreams/readablestream:2018:39)
    at ReadableStream.cancel (node:internal/webstreams/readablestream:324:12)
    at writeFromReadableStream (./node_modules/.pnpm/@hono+node-server@1.14.1_hono@4.7.7/node_modules/@hono/node-server/dist/index.mjs:170:12)
    at responseViaResponseObject (./node_modules/.pnpm/@hono+node-server@1.14.1_hono@4.7.7/node_modules/@hono/node-server/dist/index.mjs:393:15)

After debugging this, I've noticed that the cancel() method of ReadableStream returns a promise.
So what we see here in the stack is a unhandled promise exception.

I will create a bugfix PR for this.

[yusukebe]

Hi @KnisterPeter

You've created the PR, but can you share a minimal code to reproduce it? I also want to investigate it. Sorry for taking up your time.

[KnisterPeter]

Unfortunately our setup is not that easy and I failed to create a minimal reproducable system.
We only see the above error in a node.js based setup with hono, remix and msw (this is already complex I think) and then put a lot of load on the application. It usually happens when we run our integration test suite.
Then at some point during the test, this error is logged and the whole hono server is shutdown.

Maybe that description does help?

I've came up with the fix, because I've read through the node.js code and saw that the stream.cancel() call may return a promise. And I guess in some case (might be a hand written stream) that promise can reject. In that rare case, hono dies because of the unhandled promise exception.

[KnisterPeter]

This is the line in the node.js source throwing the AbortError:
https://github.com/nodejs/node/blob/ce4a16f50ae289bf6c7834b592ca47ad4634dd79/lib/internal/streams/destroy.js#L328

Looks like it fails because the stream is canceled but it's not yet completed (whatever that would mean).
Maybe it has to be consumed completely to prevent memory issues?

[KnisterPeter]

@yusukebe Please let me know what else could be helpful.

[yusukebe]

@KnisterPeter

Thank you for the comment. I'm working on fixing a similar problem. So please wait a bit.

[KnisterPeter]

Fixed by #258