Merge test_fs_open_no_permissions with test_fcntl_open. NFC (emscripten-core#23231)

Co-authored-by: Derek Schuff <[email protected]>

Author: hoodmane

test/fcntl/test_fcntl_open.c

@@ -151,8 +151,18 @@ void test() {
   errno = 0;
 }
 
+void test_open_create_no_permissions() {
+  int res = open("a", O_CREAT, 0);
+  printf("error: %s\n", strerror(errno));
+  assert(res >= 0);
+  struct stat st;
+  assert(stat("a", &st) == 0);
+  assert((st.st_mode & 0777) == 0);
+}
+
 int main() {
   setup();
   test();
+  test_open_create_no_permissions();
   return 0;
 }

test/fs/test_fs_open_no_permissions.c

@@ -5544,9 +5544,13 @@ def test_fcntl(self):
     self.add_pre_run("FS.createDataFile('/', 'test', 'abcdef', true, true, false);")
     self.do_run_in_out_file_test('fcntl/test_fcntl.c')
 
+  @crossplatform
   @also_with_nodefs_both
   @crossplatform
   def test_fcntl_open(self):
+    nodefs = '-DNODEFS' in self.emcc_args or '-DNODERAWFS' in self.emcc_args
+    if nodefs and WINDOWS:
+      self.skipTest('Stat mode behavior does not match on Windows')
     if '-DNODERAWFS' in self.emcc_args and not LINUX:
       self.skipTest('noderawfs fails here under non-linux')
     self.do_run_in_out_file_test('fcntl/test_fcntl_open.c')
@@ -5869,13 +5873,6 @@ def test_fs_rename_on_existing(self):
   def test_fs_readdir_ino_matches_stat_ino(self):
     self.do_runf('fs/test_fs_readdir_ino_matches_stat_ino.c', 'success')
 
-  @also_with_nodefs_both
-  @crossplatform
-  def test_fs_open_no_permissions(self):
-    if ('-DNODEFS' in self.emcc_args or '-DNODERAWFS' in self.emcc_args) and WINDOWS:
-      self.skipTest('fs_open_no_permissions fails on windows')
-    self.do_runf('fs/test_fs_open_no_permissions.c', 'success')
-
   @also_with_nodefs_both
   @crossplatform
   @no_windows('https://github.com/emscripten-core/emscripten/issues/8882')