Skip to content

Commit d679c87

Browse files
authored
[test] Bump memory64 node-canary requirment from v23 to v24. NFC (emscripten-core#23327)
Node v23 (which has been released) doesn't support the final version to memory64 (specifically table64). Node v24 (available via node canary builds) is the only version I know of that does.
1 parent 7eb7d79 commit d679c87

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/common.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -962,7 +962,7 @@ def require_wasm64(self):
962962
nodejs = self.get_nodejs()
963963
if nodejs:
964964
version = shared.get_node_version(nodejs)
965-
if version >= (23, 0, 0):
965+
if version >= (24, 0, 0):
966966
self.js_engines = [nodejs]
967967
return
968968

@@ -972,9 +972,9 @@ def require_wasm64(self):
972972
return
973973

974974
if 'EMTEST_SKIP_WASM64' in os.environ:
975-
self.skipTest('test requires node >= 23 or d8 (and EMTEST_SKIP_WASM64 is set)')
975+
self.skipTest('test requires node >= 24 or d8 (and EMTEST_SKIP_WASM64 is set)')
976976
else:
977-
self.fail('either d8 or node >= 23 required to run wasm64 tests. Use EMTEST_SKIP_WASM64 to skip')
977+
self.fail('either d8 or node >= 24 required to run wasm64 tests. Use EMTEST_SKIP_WASM64 to skip')
978978

979979
def require_simd(self):
980980
if self.is_browser_test():

0 commit comments

Comments
 (0)