chore: Fix lint & revert some changes to get test suite passing (#180)

* fix: Lint error

* chore: Revert previous implementation to get tests passing

* chore: Revert credentials config & credentials changes

* fix: Manual destawssqs endpoint validation

Author: alexluong

internal/destregistry/baseprovider.go

@@ -16,7 +16,7 @@ import (
 // - 10 or more characters: show first 4 characters + asterisks for the rest
 func ObfuscateValue(value string) string {
 	if len(value) < 10 {
-		return strings.Repeat("*", len(value))
+		return "****"
 	}
 	return value[:4] + strings.Repeat("*", len(value)-4)
 }

internal/destregistry/providers/destawssqs/destawssqs.go

@@ -100,6 +100,18 @@ func (d *AWSSQSDestination) resolveMetadata(ctx context.Context, destination *mo
 		return nil, nil, err
 	}
 
+	if endpoint := destination.Config["endpoint"]; endpoint != "" {
+		parsedURL, err := url.Parse(endpoint)
+		if err != nil || !parsedURL.IsAbs() || (parsedURL.Scheme != "http" && parsedURL.Scheme != "https") {
+			return nil, nil, destregistry.NewErrDestinationValidation([]destregistry.ValidationErrorDetail{
+				{
+					Field: "config.endpoint",
+					Type:  "pattern",
+				},
+			})
+		}
+	}
+
 	return &AWSSQSDestinationConfig{
 			Endpoint: destination.Config["endpoint"],
 			QueueURL: destination.Config["queue_url"],

internal/services/api/destination_handlers.go

@@ -158,11 +158,11 @@ func (h *DestinationHandlers) Update(c *gin.Context) {
 	}
 	if input.Config != nil {
 		shouldRevalidate = true
-		updatedDestination.Config = mergeStringMaps(originalDestination.Config, input.Config)
+		updatedDestination.Config = input.Config
 	}
 	if input.Credentials != nil {
 		shouldRevalidate = true
-		updatedDestination.Credentials = mergeStringMaps(originalDestination.Credentials, input.Credentials)
+		updatedDestination.Credentials = input.Credentials
 	}
 	if shouldRevalidate {
 		if err := h.registry.ValidateDestination(c.Request.Context(), &updatedDestination); err != nil {
@@ -338,17 +338,6 @@ type UpdateDestinationRequest struct {
 	Credentials models.Credentials `json:"credentials" binding:"-"`
 }
 
-func mergeStringMaps(original, input map[string]string) map[string]string {
-	merged := make(map[string]string)
-	for k, v := range original {
-		merged[k] = v
-	}
-	for k, v := range input {
-		merged[k] = v
-	}
-	return merged
-}
-
 func mustRoleFromContext(c *gin.Context) string {
 	if role, exists := c.Get(authRoleKey); exists {
 		if roleStr, ok := role.(string); ok {

internal/services/api/router.go

@@ -59,7 +59,7 @@ type routeDefinition struct {
 }
 
 // registerRoutes registers routes to the given router based on route definitions and config
-func registerRoutes(router *gin.RouterGroup, cfg RouterConfig, routes []RouteDefinition, logger *otelzap.Logger, entityStore models.EntityStore) {
+func registerRoutes(router *gin.RouterGroup, cfg RouterConfig, routes []RouteDefinition) {
 	isPortalMode := cfg.APIKey != "" && cfg.JWTSecret != ""
 
 	for _, route := range routes {
@@ -381,7 +381,7 @@ func NewRouter(
 	apiRoutes = append(apiRoutes, tenantAgnosticRoutes...)
 	apiRoutes = append(apiRoutes, tenantSpecificRoutes...)
 
-	registerRoutes(apiRouter, cfg, apiRoutes, logger, entityStore)
+	registerRoutes(apiRouter, cfg, apiRoutes)
 
 	return r
 }