fix: Count unknown value as present during attribute validation (#58)

alexluong · web-flow · commit 83de35e1a4bc · 2024-05-09T14:55:33.000+01:00
diff --git a/internal/validators/AtLeastOneChild.go b/internal/validators/AtLeastOneChild.go
@@ -21,7 +21,7 @@ func (validator atLeastOneChild) ValidateObject(ctx context.Context, req validat
 	defined := make(map[string]bool)
 	count := 0
 	for key, attr := range req.ConfigValue.Attributes() {
-		if attr.IsUnknown() || attr.IsNull() {
+		if attr.IsNull() {
 			continue
 		}
 		defined[key] = true
diff --git a/internal/validators/ExactlyOneChild.go b/internal/validators/ExactlyOneChild.go
@@ -21,7 +21,7 @@ func (validator exactlyOneChild) ValidateObject(ctx context.Context, req validat
 	defined := make(map[string]bool)
 	count := 0
 	for key, attr := range req.ConfigValue.Attributes() {
-		if attr.IsUnknown() || attr.IsNull() {
+		if attr.IsNull() {
 			continue
 		}
 		defined[key] = true

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ func (validator atLeastOneChild) ValidateObject(ctx context.Context, req validat`
`21`	`21`	`defined := make(map[string]bool)`
`22`	`22`	`count := 0`
`23`	`23`	`for key, attr := range req.ConfigValue.Attributes() {`
`24`		`- if attr.IsUnknown() \|\| attr.IsNull() {`
	`24`	`+ if attr.IsNull() {`
`25`	`25`	`continue`
`26`	`26`	`}`
`27`	`27`	`defined[key] = true`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ func (validator exactlyOneChild) ValidateObject(ctx context.Context, req validat`
`21`	`21`	`defined := make(map[string]bool)`
`22`	`22`	`count := 0`
`23`	`23`	`for key, attr := range req.ConfigValue.Attributes() {`
`24`		`- if attr.IsUnknown() \|\| attr.IsNull() {`
	`24`	`+ if attr.IsNull() {`
`25`	`25`	`continue`
`26`	`26`	`}`
`27`	`27`	`defined[key] = true`