Open
Conversation
Contributor
|
✅ Build Completed with Success, Version=1310.0.0-8a427f6 |
luanlorenzo
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR refactors the layout and accessibility of the Resources panel in the webapp. The main structural change moves the page title ("Resources") and the action button ("Setup new Resource" / "Explore Resource Catalog") inside the panel component itself, introduces a sticky header for improved UX during scrolling, and replaces the shared
infinite-scrollwrapper with per-tab lazy loading.🔗 Related Issue
Fixes ENG-276
🚀 Type of Change
📋 Changes Made
webapp/src/webapp/app.cljs: Simplified the:resources-panelroute definition — removed the outer padding/heading wrapper and delegated layout ownership toresources-main/panel. The outerBoxnow only providesbg-gray-1 min-h-full h-screen.webapp/src/webapp/resources/main.cljs: Added a sticky header (sticky top-0 z-10 bg-gray-1) that contains the "Resources" heading, the action button, the tab switcher, and the search/filter controls, keeping them visible during scroll.webapp/src/webapp/resources/main.cljs: Replaced the single sharedinfinite-scrollwrapping the entire component with individualinfinite-scrollinstances placed at the bottom of each tab's content block (resourcesandroles), so lazy loading is scoped per tab.webapp/src/webapp/resources/main.cljs: Removed the unusedcurrent-statelocal binding and replacedh-fullwithmin-h-96on loading/empty state containers for more predictable rendering.🧪 Testing
Test Configuration:
Tests performed:
📸 Screenshots
✅ Checklist