Merge pull request #73 from amardeshbd/69-fix-activity-memory-leak

[NOFIX] [#69] Unable to find the activity leak.

Author: hossain-khan

app/src/main/java/com/hossainkhan/android/demo/layoutpreview/LayoutPreviewBaseActivity.kt

@@ -78,8 +78,7 @@ open class LayoutPreviewBaseActivity : AppCompatActivity() {
 
         setContentView(layoutResourceId)
 
-        viewModel = ViewModelProvider(this, viewModelFactory)
-                .get(LayoutInfoViewModel::class.java)
+        viewModel = ViewModelProvider(this, viewModelFactory).get(LayoutInfoViewModel::class.java)
         viewModel.init(layoutResourceId)
 
         supportActionBar?.setDisplayHomeAsUpEnabled(true)
@@ -92,6 +91,12 @@ open class LayoutPreviewBaseActivity : AppCompatActivity() {
                 })
     }
 
+    override fun onStop() {
+        super.onStop()
+        flashbar?.dismiss()
+        flashbar = null
+    }
+
     private fun updateActionBar(layoutInformation: LayoutInformation) {
         supportActionBar?.title = layoutInformation.title
     }
@@ -144,7 +149,7 @@ open class LayoutPreviewBaseActivity : AppCompatActivity() {
         builder.setShowTitle(false)
                 .addDefaultShareMenuItem()
         val customTabsIntent = builder.build()
-        customTabsIntent.launchUrl(this, Uri.parse(viewModel.layoutUrl))
+        customTabsIntent.launchUrl(applicationContext, Uri.parse(viewModel.layoutUrl))
     }
 
 

build.gradle

@@ -107,7 +107,7 @@ ext {
     daggerVersion = '2.15' // https://github.com/google/dagger
     timberLibraryVersion = '4.7.1' // https://github.com/JakeWharton/timber
     leakcanaryLibraryVersion = '1.6.3' // https://github.com/square/leakcanary/releases
-    flashBarVersion = '1.0.2' // https://github.com/aritraroy/Flashbar/releases
+    flashBarVersion = '1.0.3' // https://github.com/aritraroy/Flashbar/releases
 }
 
 //