Skip to content

Commit c865a4b

Browse files
committed
add macos to build matrix (skip tests using docker)
1 parent 296fc59 commit c865a4b

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
matrix:
3333
os:
3434
- ubuntu-latest
35-
# - macos-latest
35+
- macos-latest
3636
rust: [stable]
3737
steps:
3838
- uses: actions/checkout@v4
@@ -71,7 +71,12 @@ jobs:
7171
run: cargo clippy --all-targets --all-features --no-deps -- -D warnings
7272

7373
- name: Run tests
74-
run: cargo test --all-features
74+
run: |
75+
if [[ "$RUNNER_OS" == "macOS" ]]; then
76+
cargo test --features skip-tests-with-docker
77+
else
78+
cargo test
79+
fi
7580
7681
- name: Check documentation
7782
run: cargo doc --no-deps --all-features

Cargo.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,7 @@ tempfile = "3.14"
2323
anyhow = "1.0"
2424
aws-sdk-s3 = "1.75"
2525
aws-credential-types = "1.2"
26+
27+
[features]
28+
# Allow skipping tests that use docker (in CI, macos doesn't support docker).
29+
skip-tests-with-docker = []

tests/object_store_integration_test.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ async fn create_s3_test_catalog(
200200
}
201201

202202
#[tokio::test]
203+
#[cfg_attr(feature = "skip-docker-tests", ignore)]
203204
async fn test_minio_object_store_integration() -> anyhow::Result<()> {
204205
// Tests DataFusion-DuckLake reading from S3/MinIO with DuckDB-created data
205206

0 commit comments

Comments
 (0)