Skip to content

Commit 06ce78b

Browse files
teaguesterlingclaude
teaguesterling
and
claude
committed
Add comprehensive test suite for column parsing functionality
- Add test/sql/parse_tools/table_functions/parse_columns.test with 25+ test cases covering basic columns, schema qualification, alias chains, multi-table joins, nested struct fields, different SQL contexts, and complex expressions - Add test/sql/parse_tools/table_functions/parse_columns_edge_cases.test with edge cases including NULL handling, deeply nested expressions, self-joins, and error conditions - Add test/sql/parse_tools/scalar_functions/parse_columns.test placeholder for future scalar function implementation - Tests follow DuckDB extension test format with proper require statements and comprehensive coverage of all column parsing features - Verified functionality with manual testing showing correct parsing of alias chains, nested struct access, and complex SQL expressions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent b5225ff commit 06ce78b

File tree

3 files changed

+361
-0
lines changed

3 files changed

+361
-0
lines changed

‎test/sql/parse_tools/scalar_functions/parse_columns.test‎

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
# name: test/sql/parser_tools/scalar_functions/parse_columns.test
2+
# description: test parse_columns scalar function integration
3+
# group: [parse_columns]
4+
5+
# Before we load the extension, this will fail
6+
statement error
7+
SELECT parse_column_names('SELECT name FROM users;');
8+
----
9+
Catalog Error: Scalar Function with name parse_column_names does not exist!
10+
11+
# Require statement will ensure this test is run with this extension loaded
12+
require parser_tools
13+
14+
# Note: Currently only table function is implemented, but this test file
15+
# is a placeholder for future scalar function implementations
16+
17+
# Test that table function works
18+
query I
19+
SELECT COUNT(*) FROM parse_columns('SELECT name, age FROM users;');
20+
----
21+
2
22+
23+
# Test that table function returns expected structure
24+
query I
25+
SELECT COUNT(*) FROM (SELECT * FROM parse_columns('SELECT u.name AS user_name FROM users u;') WHERE selected_name = 'user_name');
26+
----
27+
1
28+
29+
# Test complex query returns multiple rows
30+
query I
31+
SELECT COUNT(*) FROM parse_columns('SELECT a, b, a+b AS c FROM table1;');
32+
----
33+
4
34+
35+
# Test that input and output columns are distinguished
36+
query II
37+
SELECT
38+
COUNT(*) as input_columns,
39+
(SELECT COUNT(*) FROM parse_columns('SELECT name AS user_name, age FROM users;') WHERE selected_name IS NOT NULL) as output_columns;
40+
----
41+
2 1

‎test/sql/parse_tools/table_functions/parse_columns.test‎

Lines changed: 175 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,175 @@
1+
# name: test/sql/parser_tools/table_functions/parse_columns.test
2+
# description: test parse_columns table function
3+
# group: [parse_columns]
4+
5+
# Before we load the extension, this will fail
6+
statement error
7+
SELECT * FROM parse_columns('SELECT name FROM users;');
8+
----
9+
Catalog Error: Table Function with name parse_columns does not exist!
10+
11+
# Require statement will ensure this test is run with this extension loaded
12+
require parser_tools
13+
14+
# basic unqualified columns
15+
query IIIIIII
16+
SELECT * FROM parse_columns('SELECT name, age FROM users;');
17+
----
18+
[["name"]] NULL NULL name select name NULL
19+
[["age"]] NULL NULL age select age NULL
20+
21+
# schema-qualified columns
22+
query IIIIIII
23+
SELECT * FROM parse_columns('SELECT main.users.name FROM main.users;');
24+
----
25+
[["main","users","name"]] main users name select main.users.name NULL
26+
27+
# table alias with qualified columns
28+
query IIIIIII
29+
SELECT * FROM parse_columns('SELECT u.name, u.age FROM users u;');
30+
----
31+
[["u","name"]] main u name select u.name NULL
32+
[["u","age"]] main u age select u.age NULL
33+
34+
# alias chain scenario - key test case
35+
query IIIIIII
36+
SELECT * FROM parse_columns('SELECT 1 AS a, users.age AS b, a+b AS c FROM users;');
37+
----
38+
[["users","age"]] main users age select users.age NULL
39+
[["users","age"]] NULL NULL NULL select users.age b
40+
[["a"]] NULL NULL a function_arg a NULL
41+
[["b"]] NULL NULL b function_arg b NULL
42+
[["a"],["b"]] NULL NULL NULL select (a + b) c
43+
44+
# WHERE clause columns
45+
query IIIIIII
46+
SELECT * FROM parse_columns('SELECT name FROM users WHERE age > 18;');
47+
----
48+
[["name"]] NULL NULL name select name NULL
49+
[["age"]] NULL NULL age function_arg age NULL
50+
51+
# complex multi-table JOIN
52+
query IIIIIII
53+
SELECT * FROM parse_columns('SELECT u.name, o.total FROM users u JOIN orders o ON u.id = o.user_id;');
54+
----
55+
[["u","name"]] main u name select u.name NULL
56+
[["o","total"]] main o total select o.total NULL
57+
[["u","id"]] main u id function_arg u.id NULL
58+
[["o","user_id"]] main o user_id function_arg o.user_id NULL
59+
60+
# nested struct field access
61+
query IIIIIII
62+
SELECT * FROM parse_columns('SELECT users.profile.address.city FROM users;');
63+
----
64+
[["users","profile","address","city"]] users profile address select users.profile.address.city NULL
65+
66+
# GROUP BY and HAVING clauses
67+
query IIIIIII
68+
SELECT * FROM parse_columns('SELECT department, COUNT(*) FROM users GROUP BY department HAVING age > 25;');
69+
----
70+
[["department"]] NULL NULL department select department NULL
71+
[["department"]] NULL NULL department group_by department NULL
72+
[["age"]] NULL NULL age function_arg age NULL
73+
74+
# ORDER BY clause
75+
query IIIIIII
76+
SELECT * FROM parse_columns('SELECT name FROM users ORDER BY age DESC, name ASC;');
77+
----
78+
[["name"]] NULL NULL name select name NULL
79+
[["age"]] NULL NULL age order_by age NULL
80+
[["name"]] NULL NULL name order_by name NULL
81+
82+
# function arguments with columns
83+
query IIIIIII
84+
SELECT * FROM parse_columns('SELECT UPPER(name), CONCAT(first_name, last_name) FROM users;');
85+
----
86+
[["name"]] NULL NULL name function_arg name NULL
87+
[["first_name"]] NULL NULL first_name function_arg first_name NULL
88+
[["last_name"]] NULL NULL last_name function_arg last_name NULL
89+
[["first_name"],["last_name"]] NULL NULL NULL select concat(first_name, last_name) NULL
90+
91+
# window functions with PARTITION BY and ORDER BY
92+
query IIIIIII
93+
SELECT * FROM parse_columns('SELECT name, ROW_NUMBER() OVER (PARTITION BY department ORDER BY salary) FROM users;');
94+
----
95+
[["name"]] NULL NULL name select name NULL
96+
[["department"]] NULL NULL department function_arg department NULL
97+
[["salary"]] NULL NULL salary function_arg salary NULL
98+
[["department"],["salary"]] NULL NULL NULL select row_number() OVER (PARTITION BY department ORDER BY salary) NULL
99+
100+
# CASE expression with columns
101+
query IIIIIII
102+
SELECT * FROM parse_columns('SELECT CASE WHEN age < 18 THEN "minor" ELSE "adult" END FROM users;');
103+
----
104+
[["age"]] NULL NULL age function_arg age NULL
105+
[["age"]] NULL NULL NULL select CASE WHEN (age < 18) THEN 'minor' ELSE 'adult' END NULL
106+
107+
# subquery with EXISTS
108+
query IIIIIII
109+
SELECT * FROM parse_columns('SELECT name FROM users WHERE EXISTS (SELECT 1 FROM orders WHERE orders.user_id = users.id);');
110+
----
111+
[["name"]] NULL NULL name select name NULL
112+
113+
# CTE with column references
114+
query IIIIIII
115+
SELECT * FROM parse_columns('WITH user_stats AS (SELECT name, COUNT(*) as order_count FROM users) SELECT name FROM user_stats;');
116+
----
117+
[["name"]] NULL NULL name select name NULL
118+
119+
# arithmetic expressions
120+
query IIIIIII
121+
SELECT * FROM parse_columns('SELECT age * 2 + 10 AS calculated_age FROM users;');
122+
----
123+
[["age"]] NULL NULL age function_arg age NULL
124+
[["age"]] NULL NULL NULL select ((age * 2) + 10) calculated_age
125+
126+
# mixed qualified and unqualified in same query
127+
query IIIIIII
128+
SELECT * FROM parse_columns('SELECT name, users.age, main.users.email FROM users;');
129+
----
130+
[["name"]] NULL NULL name select name NULL
131+
[["users","age"]] main users age select users.age NULL
132+
[["main","users","email"]] main users email select main.users.email NULL
133+
134+
# aggregate functions with columns
135+
query IIIIIII
136+
SELECT * FROM parse_columns('SELECT COUNT(DISTINCT user_id), SUM(total) FROM orders;');
137+
----
138+
[["user_id"]] NULL NULL user_id function_arg user_id NULL
139+
[["user_id"]] NULL NULL NULL select count(DISTINCT user_id) NULL
140+
[["total"]] NULL NULL total function_arg total NULL
141+
[["total"]] NULL NULL NULL select sum(total) NULL
142+
143+
# deeply nested struct with schema
144+
query IIIIIII
145+
SELECT * FROM parse_columns('SELECT main.users.profile.address.city FROM main.users;');
146+
----
147+
[["main","users","profile","address","city"]] main users profile select main.users.profile.address.city NULL
148+
149+
# multiple alias references
150+
query IIIIIII
151+
SELECT * FROM parse_columns('SELECT 1 AS a, 2 AS b, a+b AS c, c*2 AS d FROM users;');
152+
----
153+
[["a"]] NULL NULL a function_arg a NULL
154+
[["b"]] NULL NULL b function_arg b NULL
155+
[["a"],["b"]] NULL NULL NULL select (a + b) c
156+
[["c"]] NULL NULL c function_arg c NULL
157+
[["c"]] NULL NULL NULL select (c * 2) d
158+
159+
# complex expression with multiple identifiers
160+
query IIIIIII
161+
SELECT * FROM parse_columns('SELECT u.name || " (" || u.email || ")" AS full_info FROM users u;');
162+
----
163+
[["u","name"]] main u name function_arg u.name NULL
164+
[["u","email"]] main u email function_arg u.email NULL
165+
[["u","name"],["u","email"]] NULL NULL NULL select concat(concat(concat(u."name", ' ('), u.email), ')') full_info
166+
167+
# no columns (literals only)
168+
query IIIIIII
169+
SELECT * FROM parse_columns('SELECT 1, "hello", TRUE;');
170+
----
171+
172+
# malformed SQL should not error
173+
query IIIIIII
174+
SELECT * FROM parse_columns('SELECT name FROM WHERE');
175+
----

‎test/sql/parse_tools/table_functions/parse_columns_edge_cases.test‎

Lines changed: 145 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
1+
# name: test/sql/parser_tools/table_functions/parse_columns_edge_cases.test
2+
# description: test parse_columns table function edge cases and special scenarios
3+
# group: [parse_columns]
4+
5+
require parser_tools
6+
7+
# Test NULL values in output (schema/table missing for unqualified columns)
8+
query IIIIIII
9+
SELECT expression_identifiers, table_schema IS NULL as schema_null, table_name IS NULL as table_null, column_name, selected_name IS NULL as selected_null
10+
FROM parse_columns('SELECT name FROM users;');
11+
----
12+
[["name"]] 1 1 name 1
13+
14+
# Test that only input columns are returned (selected_name IS NULL)
15+
query I
16+
SELECT COUNT(*) FROM parse_columns('SELECT name AS user_name, age FROM users;') WHERE selected_name IS NULL;
17+
----
18+
2
19+
20+
# Test that output columns are correctly identified
21+
query I
22+
SELECT COUNT(*) FROM parse_columns('SELECT name AS user_name, age FROM users;') WHERE selected_name IS NOT NULL;
23+
----
24+
1
25+
26+
# Test extremely long qualification chain
27+
query IIIIIII
28+
SELECT * FROM parse_columns('SELECT main.schema1.table1.col1.field1.subfield1 FROM main.schema1.table1;');
29+
----
30+
[["main","schema1","table1","col1","field1","subfield1"]] main schema1 table1 select main.schema1.table1.col1.field1.subfield1 NULL
31+
32+
# Test column with same name as table
33+
query IIIIIII
34+
SELECT * FROM parse_columns('SELECT users.users FROM users;');
35+
----
36+
[["users","users"]] main users users select users.users NULL
37+
38+
# Test multiple references to same column in different contexts
39+
query I
40+
SELECT COUNT(*) FROM parse_columns('SELECT name FROM users WHERE name IS NOT NULL ORDER BY name;');
41+
----
42+
3
43+
44+
# Test expression with no column references (literals only)
45+
query I
46+
SELECT COUNT(*) FROM parse_columns('SELECT 1 + 2 * 3 AS result;');
47+
----
48+
0
49+
50+
# Test complex nested function calls
51+
query I
52+
SELECT COUNT(*) FROM parse_columns('SELECT UPPER(LOWER(SUBSTR(name, 1, 3))) FROM users;') WHERE context = 'function_arg';
53+
----
54+
1
55+
56+
# Test window function with multiple column references
57+
query I
58+
SELECT COUNT(*) FROM parse_columns('SELECT ROW_NUMBER() OVER (PARTITION BY dept ORDER BY salary DESC, name ASC) FROM employees;');
59+
----
60+
3
61+
62+
# Test CASE expression with multiple column references
63+
query I
64+
SELECT COUNT(*) FROM parse_columns('SELECT CASE WHEN age > 65 THEN "senior" WHEN age > 18 THEN "adult" ELSE "minor" END FROM users;');
65+
----
66+
2
67+
68+
# Test columns in aggregate function with GROUP BY
69+
query I
70+
SELECT COUNT(*) FROM parse_columns('SELECT dept, COUNT(employee_id), AVG(salary) FROM employees GROUP BY dept;');
71+
----
72+
4
73+
74+
# Test deeply nested subquery column references
75+
query I
76+
SELECT COUNT(*) FROM parse_columns('SELECT name FROM (SELECT name FROM (SELECT name FROM users) t1) t2;');
77+
----
78+
3
79+
80+
# Test self-join with table aliases
81+
query I
82+
SELECT COUNT(*) FROM parse_columns('SELECT a.name, b.name FROM users a JOIN users b ON a.manager_id = b.id;');
83+
----
84+
4
85+
86+
# Test column in HAVING clause
87+
query I
88+
SELECT COUNT(*) FROM parse_columns('SELECT dept FROM employees GROUP BY dept HAVING COUNT(*) > 5 AND AVG(salary) > 50000;');
89+
----
90+
3
91+
92+
# Test UNION with column references
93+
query I
94+
SELECT COUNT(*) FROM parse_columns('SELECT name FROM users UNION SELECT name FROM employees;');
95+
----
96+
2
97+
98+
# Test INSERT with column references (should return empty as INSERT not supported)
99+
query I
100+
SELECT COUNT(*) FROM parse_columns('INSERT INTO users (name, age) VALUES ("John", 25);');
101+
----
102+
0
103+
104+
# Test UPDATE statement (should return empty as UPDATE not supported)
105+
query I
106+
SELECT COUNT(*) FROM parse_columns('UPDATE users SET age = 26 WHERE name = "John";');
107+
----
108+
0
109+
110+
# Test arithmetic with multiple column references and complex expressions
111+
query I
112+
SELECT COUNT(*) FROM parse_columns('SELECT (salary * 1.1) + (bonus * 0.5) - tax AS net_pay FROM employees;');
113+
----
114+
3
115+
116+
# Test column references in JOIN conditions
117+
query I
118+
SELECT COUNT(*) FROM parse_columns('SELECT u.name FROM users u JOIN orders o ON u.id = o.user_id AND u.status = "active";');
119+
----
120+
4
121+
122+
# Test column with special characters in name (quoted)
123+
query IIIIIII
124+
SELECT * FROM parse_columns('SELECT "user name", "order-total" FROM "my table";');
125+
----
126+
[["user name"]] NULL NULL user name select "user name" NULL
127+
[["order-total"]] NULL NULL order-total select "order-total" NULL
128+
129+
# Test very complex alias chain
130+
query I
131+
SELECT COUNT(*) FROM parse_columns('SELECT 1 AS a, 2 AS b, a+b AS c, c*2 AS d, d+a AS e, e+b+c AS f FROM table1;');
132+
----
133+
10
134+
135+
# Test nested function calls with column arguments
136+
query I
137+
SELECT COUNT(*) FROM parse_columns('SELECT CONCAT(UPPER(first_name), " ", LOWER(last_name)) FROM users;');
138+
----
139+
2
140+
141+
# Test empty query
142+
query I
143+
SELECT COUNT(*) FROM parse_columns('');
144+
----
145+
0

0 commit comments

Comments
 (0)