Skip to content

Commit 5dece21

Browse files
committed
switch methods to static
1 parent 2c40b51 commit 5dece21

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

src/include/parse_tables.hpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,13 @@ struct TableRefResult {
2525
TableContext context;
2626
};
2727

28-
void ExtractTablesFromSQL(const std::string &sql, std::vector<TableRefResult> &results);
28+
static void ExtractTablesFromSQL(const std::string &sql, std::vector<TableRefResult> &results);
29+
static void ExtractTablesFromQueryNode(
30+
const duckdb::QueryNode &node,
31+
std::vector<TableRefResult> &results,
32+
const TableContext context = TableContext::From,
33+
const duckdb::CommonTableExpressionMap *cte_map = nullptr
34+
);
2935

3036
void RegisterParseTablesFunction(duckdb::DatabaseInstance &db);
3137
void RegisterParseTableScalarFunction(DatabaseInstance &db);

src/parse_tables.cpp

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,6 @@ static unique_ptr<GlobalTableFunctionState> ParseTablesInit(ClientContext &conte
7171
return make_uniq<ParseTablesState>();
7272
}
7373

74-
static void ExtractTablesFromQueryNode(
75-
const duckdb::QueryNode &node,
76-
std::vector<TableRefResult> &results,
77-
const TableContext context = TableContext::From,
78-
const duckdb::CommonTableExpressionMap *cte_map = nullptr
79-
);
80-
8174
static void ExtractTablesFromRef(
8275
const duckdb::TableRef &ref,
8376
std::vector<TableRefResult> &results,
@@ -152,7 +145,7 @@ static void ExtractTablesFromQueryNode(
152145
}
153146
}
154147

155-
void ExtractTablesFromSQL(const std::string &sql, std::vector<TableRefResult> &results) {
148+
static void ExtractTablesFromSQL(const std::string &sql, std::vector<TableRefResult> &results) {
156149
Parser parser;
157150
parser.ParseQuery(sql);
158151

@@ -168,7 +161,7 @@ void ExtractTablesFromSQL(const std::string &sql, std::vector<TableRefResult> &r
168161
}
169162
}
170163

171-
void ExtractTablesFromSQL(const std::string & sql, std::vector<TableRefResult> &result, std::unordered_set<std::string> excluded_types) {
164+
static void ExtractTablesFromSQL(const std::string & sql, std::vector<TableRefResult> &result, std::unordered_set<std::string> excluded_types) {
172165
std::vector<TableRefResult> temp_result;
173166
ExtractTablesFromSQL(sql, temp_result);
174167
std::unordered_set<TableContext> e_types;

0 commit comments

Comments
 (0)