don't fail on parser exceptions

Author: zacMode

src/parse_tables.cpp

@@ -147,7 +147,14 @@ static void ExtractTablesFromQueryNode(
 
 static void ExtractTablesFromSQL(const std::string &sql, std::vector<TableRefResult> &results) {
     Parser parser;
-    parser.ParseQuery(sql);
+
+    try {
+        parser.ParseQuery(sql);
+    } catch (const ParserException &ex) {
+        // swallow parser exceptions to make this function more robust. is_parsable can be used if needed
+        return; 
+    }
+    
 
     for (auto &stmt : parser.statements) {
         if (stmt->type == StatementType::SELECT_STATEMENT) {

test/sql/parse_tools/scalar_functions/parse_table_names.test

@@ -72,3 +72,9 @@ query I
 select parse_table_names('SELECT 1;');
 ----
 []
+
+# malformed SQL should not error
+query I
+SELECT parse_table_names('SELECT * FROM WHERE');
+----
+[]

test/sql/parse_tools/scalar_functions/parse_tables.test

@@ -68,3 +68,9 @@ query I
 select parse_tables('SELECT 1;');
 ----
 []
+
+# malformed SQL should not error
+query I
+SELECT parse_tables('SELECT * FROM WHERE');
+----
+[]

test/sql/parse_tools/table_functions/parse_tables.test

@@ -110,8 +110,7 @@ query III
 SELECT * FROM parse_tables('SELECT 1;');
 ----
 
-# malformed SQL should error
-statement error
+# malformed SQL should not error
+query III
 SELECT * FROM parse_tables('SELECT * FROM WHERE');
-----
-Parser Error: syntax error at or near "WHERE"
+----