exclude from_cte, and add more unit tests

Author: zacMode

src/parse_tables.cpp

@@ -234,6 +234,7 @@ static void ParseTablesScalarFunction(DataChunk &args, ExpressionState &state, V
         if (exclude_cte) {
             std::unordered_set<std::string> excluded_types;
             excluded_types.insert("cte");
+            excluded_types.insert("from_cte");
             ExtractTablesFromSQL(query_string, parsed_tables, excluded_types);
         } else {
             ExtractTablesFromSQL(query_string, parsed_tables);

test/sql/parse_tools/scalar_functions/parse_table_names.test

@@ -14,4 +14,22 @@ require parser_tools
 query I
 SELECT parse_table_names('select * from MyTable');
 ----
-[MyTable]
+[MyTable]
+
+# default behavior: exclude CTE
+query I
+SELECT parse_table_names('with cte_test as(select 1) select * from MyTable, cte_test');
+----
+[MyTable]
+
+# default behavior: exclude CTE (explicitly specify true)
+query I
+SELECT parse_table_names('with cte_test as(select 1) select * from MyTable, cte_test', true);
+----
+[MyTable]
+
+# test optional bool argument: don't exclude CTE tables
+query I
+SELECT parse_table_names('with cte_test as(select 1) select * from MyTable, cte_test', false);
+----
+[cte_test, MyTable, cte_test]