Skip to content

Commit 5af3365

Browse files
committed
cargo fmt
1 parent 49a7365 commit 5af3365

File tree

11 files changed

+64
-48
lines changed

11 files changed

+64
-48
lines changed

src/catalog/backend.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,4 +309,3 @@ where
309309
Ok(())
310310
}
311311
}
312-

src/catalog/sqlite_manager.rs

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -275,19 +275,17 @@ impl CatalogManager for SqliteCatalogManager {
275275
.execute(self.backend.pool())
276276
.await?
277277
}
278-
None => {
279-
sqlx::query(
280-
"UPDATE secrets SET provider = ?, provider_ref = ?, status = ?, updated_at = ? \
278+
None => sqlx::query(
279+
"UPDATE secrets SET provider = ?, provider_ref = ?, status = ?, updated_at = ? \
281280
WHERE name = ?",
282-
)
283-
.bind(&metadata.provider)
284-
.bind(&metadata.provider_ref)
285-
.bind(metadata.status.as_str())
286-
.bind(&updated_at)
287-
.bind(&metadata.name)
288-
.execute(self.backend.pool())
289-
.await?
290-
}
281+
)
282+
.bind(&metadata.provider)
283+
.bind(&metadata.provider_ref)
284+
.bind(metadata.status.as_str())
285+
.bind(&updated_at)
286+
.bind(&metadata.name)
287+
.execute(self.backend.pool())
288+
.await?,
291289
};
292290

293291
Ok(result.rows_affected() > 0)

src/datafetch/native/postgres.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ pub async fn resolve_connection_string(
6161
.await
6262
.map_err(|e| DataFetchError::Connection(e.to_string()))?;
6363

64-
Ok(build_connection_string(host, port, user, database, &password))
64+
Ok(build_connection_string(
65+
host, port, user, database, &password,
66+
))
6567
}
6668

6769
/// Connect to PostgreSQL with automatic SSL retry.

src/secrets/backend.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,10 @@ pub trait SecretBackend: Debug + Send + Sync {
6363
///
6464
/// Returns a `BackendWrite` so the manager knows whether it was a create
6565
/// vs update and can persist any backend-provided metadata.
66-
async fn put(&self, record: &SecretRecord, value: &[u8])
67-
-> Result<BackendWrite, BackendError>;
66+
async fn put(&self, record: &SecretRecord, value: &[u8]) -> Result<BackendWrite, BackendError>;
6867

6968
/// Delete the entry identified by `record`.
7069
///
7170
/// Returns `true` if something was deleted, `false` if it didn't exist.
7271
async fn delete(&self, record: &SecretRecord) -> Result<bool, BackendError>;
73-
}
72+
}

src/secrets/encrypted_catalog_backend.rs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,7 @@ impl SecretBackend for EncryptedCatalogBackend {
9797
}
9898
}
9999

100-
async fn put(
101-
&self,
102-
record: &SecretRecord,
103-
value: &[u8],
104-
) -> Result<BackendWrite, BackendError> {
100+
async fn put(&self, record: &SecretRecord, value: &[u8]) -> Result<BackendWrite, BackendError> {
105101
// Encrypt the value using the secret name as AAD
106102
let ciphertext = encrypt(&self.key, value, &record.name)
107103
.map_err(|e| BackendError::Storage(format!("Encryption failed: {}", e)))?;
@@ -268,7 +264,10 @@ mod tests {
268264
let result = backend2.get(&rec).await;
269265

270266
assert!(result.is_err());
271-
assert!(result.unwrap_err().to_string().contains("Decryption failed"));
267+
assert!(result
268+
.unwrap_err()
269+
.to_string()
270+
.contains("Decryption failed"));
272271
}
273272

274273
#[tokio::test]
@@ -308,4 +307,4 @@ mod tests {
308307
let result = EncryptedCatalogBackend::from_base64_key("not-valid-base64!!!", catalog);
309308
assert!(result.is_err());
310309
}
311-
}
310+
}

src/secrets/encryption.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ const HEADER_SIZE: usize = 4 + 1 + 1 + NONCE_SIZE; // 18 bytes
2525
/// * `plaintext` - Data to encrypt
2626
/// * `aad` - Associated authenticated data (secret name, prevents blob swapping)
2727
pub fn encrypt(key: &[u8; 32], plaintext: &[u8], aad: &str) -> Result<Vec<u8>, EncryptError> {
28-
let cipher = Aes256GcmSiv::new_from_slice(key)
29-
.map_err(|e| EncryptError::CipherInit(e.to_string()))?;
28+
let cipher =
29+
Aes256GcmSiv::new_from_slice(key).map_err(|e| EncryptError::CipherInit(e.to_string()))?;
3030

3131
// Generate random nonce
3232
let mut nonce_bytes = [0u8; NONCE_SIZE];
@@ -89,8 +89,8 @@ pub fn decrypt(key: &[u8; 32], encrypted: &[u8], aad: &str) -> Result<Vec<u8>, D
8989
.expect("slice length matches NONCE_SIZE");
9090
let ciphertext = &encrypted[HEADER_SIZE..];
9191

92-
let cipher = Aes256GcmSiv::new_from_slice(key)
93-
.map_err(|e| DecryptError::CipherInit(e.to_string()))?;
92+
let cipher =
93+
Aes256GcmSiv::new_from_slice(key).map_err(|e| DecryptError::CipherInit(e.to_string()))?;
9494

9595
let nonce = Nonce::from(nonce_bytes);
9696

@@ -233,4 +233,4 @@ mod tests {
233233
let decrypted = decrypt(&key, &encrypted, "name").unwrap();
234234
assert_eq!(decrypted, plaintext);
235235
}
236-
}
236+
}

src/source.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@ impl Credential {
1919
match self {
2020
Credential::None => Err(anyhow::anyhow!("no credential configured")),
2121
Credential::SecretRef { name } => {
22-
let bytes = secrets.get(name).await.map_err(|e| {
23-
anyhow::anyhow!("failed to resolve secret '{}': {}", name, e)
24-
})?;
22+
let bytes = secrets
23+
.get(name)
24+
.await
25+
.map_err(|e| anyhow::anyhow!("failed to resolve secret '{}': {}", name, e))?;
2526
String::from_utf8(bytes)
2627
.map_err(|_| anyhow::anyhow!("secret '{}' is not valid UTF-8", name))
2728
}

tests/catalog_manager_suite.rs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -479,15 +479,10 @@ macro_rules! catalog_manager_tests {
479479
};
480480

481481
// First create should succeed
482-
catalog
483-
.create_secret_metadata(&metadata)
484-
.await
485-
.unwrap();
482+
catalog.create_secret_metadata(&metadata).await.unwrap();
486483

487484
// Second create with same name should fail (unique constraint)
488-
let result = catalog
489-
.create_secret_metadata(&metadata)
490-
.await;
485+
let result = catalog.create_secret_metadata(&metadata).await;
491486

492487
assert!(result.is_err());
493488
}

tests/datafetch_tests.rs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,14 @@ async fn test_duckdb_fetch_table() {
155155
let mut writer = StreamingParquetWriter::new(output_path.clone());
156156

157157
let result = fetcher
158-
.fetch_table(&source, &secrets, None, "test_schema", "products", &mut writer)
158+
.fetch_table(
159+
&source,
160+
&secrets,
161+
None,
162+
"test_schema",
163+
"products",
164+
&mut writer,
165+
)
159166
.await;
160167
assert!(result.is_ok(), "Fetch should succeed: {:?}", result.err());
161168

@@ -187,4 +194,4 @@ async fn test_duckdb_fetch_table() {
187194
assert!(schema.field_with_name("name").is_ok());
188195
assert!(schema.field_with_name("price").is_ok());
189196
assert!(schema.field_with_name("in_stock").is_ok());
190-
}
197+
}

tests/http_server_tests.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,10 @@ async fn test_update_secret() -> Result<()> {
802802

803803
// Verify updated_at is different from created_at
804804
let updated_at = update_json["updated_at"].as_str().unwrap();
805-
assert_ne!(created_at, updated_at, "updated_at should change after update");
805+
assert_ne!(
806+
created_at, updated_at,
807+
"updated_at should change after update"
808+
);
806809

807810
// Verify the new value can be retrieved via the manager
808811
let secret_value = app.engine.secret_manager().get("test_secret").await?;

0 commit comments

Comments
 (0)