From 77f8c78adeb0da2c2030f66e2df44854c01d9d29 Mon Sep 17 00:00:00 2001
From: Matheus Richard <matheusrichardt@gmail.com>
Date: Fri, 25 Jul 2025 18:22:29 -0300
Subject: [PATCH] Fix Chrome autocomplete incorrectly triggerring actions

When using a Stimulus action like

    <button data-action="keydown.meta+k@window->search#open">

in Google Chrome, clicking an input's autocomplete suggestion
unexpectedly triggers the controller action even though no key is
pressed.

It seems that Chrome dispatches an Event with type === "keydown", but it
is not an instance of KeyboardEvent. This happens regardless of the key
filter.

Closes #852
---
 src/core/binding.ts                                    | 9 +++++++--
 src/tests/modules/core/action_keyboard_filter_tests.ts | 8 ++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/src/core/binding.ts b/src/core/binding.ts
index 33958667..5526fc1b 100644
--- a/src/core/binding.ts
+++ b/src/core/binding.ts
@@ -86,8 +86,13 @@ export class Binding {
   private willBeInvokedByEvent(event: Event): boolean {
     const eventTarget = event.target
 
-    if (event instanceof KeyboardEvent && this.action.shouldIgnoreKeyboardEvent(event)) {
-      return false
+    if (event.type === "keydown") {
+      // when accepting an autocomplete suggestion, Chrome dispatches a keydown event,
+      // but it isn't a KeyboardEvent instance
+      const keyboardEvent: KeyboardEvent = event instanceof KeyboardEvent ? event : new KeyboardEvent("keydown")
+      if (this.action.shouldIgnoreKeyboardEvent(keyboardEvent)) {
+        return false
+      }
     }
 
     if (event instanceof MouseEvent && this.action.shouldIgnoreMouseEvent(event)) {
diff --git a/src/tests/modules/core/action_keyboard_filter_tests.ts b/src/tests/modules/core/action_keyboard_filter_tests.ts
index 64a9303c..73f1f6e7 100644
--- a/src/tests/modules/core/action_keyboard_filter_tests.ts
+++ b/src/tests/modules/core/action_keyboard_filter_tests.ts
@@ -197,4 +197,12 @@ export default class ActionKeyboardFilterTests extends LogControllerTestCase {
     await this.triggerEvent(button, "jquery.a")
     this.assertActions({ name: "log2", identifier: "a", eventType: "jquery.a", currentTarget: button })
   }
+
+  async "test ignore events dispatched by autocomplete"() {
+    const button = this.findElement("#button10")
+    await this.nextFrame
+    await this.triggerEvent(button, "keydown", {})
+
+    this.assertNoActions()
+  }
 }