Skip to content

Commit dda27a8

Browse files
committed
Restrict tests to minitest<6
There are currently [CI Failures][] related to the latest version of `minitest`: ``` /opt/hostedtoolcache/Ruby/3.2.9/x64/lib/ruby/gems/3.2.0/gems/railties-8.1.1/lib/rails/test_unit/line_filtering.rb:7:in `run': wrong number of arguments (given 3, expected 1..2) (ArgumentError) ``` Until the latest Rails releases on stable branches adopt support for `minitest > 6`, fix the version in the `bug_report_template.rb` inline Gemfile. The unbounded minitest version is also negatively impacting the rest of the [test suite][]: ``` <internal:/opt/hostedtoolcache/Ruby/3.2.9/x64/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require': cannot load such file -- minitest/mock (LoadError) ``` Include a `< 6` version constraint in the `Gemfile` as well. [CI Failures]: https://github.com/hotwired/turbo-rails/actions/runs/20479960692/job/58886338414?pr=736#step:4:200 [test suite]: https://github.com/hotwired/turbo-rails/actions/runs/20492294729/job/58886518537?pr=774#step:6:19
1 parent 0eb3c03 commit dda27a8

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,6 @@ group :test do
2626
gem 'capybara'
2727
gem 'rexml'
2828
gem 'cuprite', '~> 0.9', require: 'capybara/cuprite'
29+
gem 'minitest', '< 6'
2930
gem 'sqlite3'
3031
end

bug_report_template.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
gem "capybara"
1313
gem "cuprite", require: "capybara/cuprite"
14+
gem "minitest", "< 6"
1415
end
1516

1617
ENV["DATABASE_URL"] = "sqlite3::memory:"

0 commit comments

Comments
 (0)