Morphing fails when refreshing after turbo stream

[AlphonseSantoro]

Came across a bug when calling the action turbo_stream.action(:refresh, nil, type: 'morph'), when the form is submitted and this refresh action is called i get this error:

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'id')
    at removeElementFromAncestorsIdMaps

Which seems very much like this issue in idiomorph, any chance that we can bump idiomorph to 0.7.3 to get that fix inn?

[htcarr3]

I think that there are a number of recent updates in idiomorph that solve issues around safe id-querying (I'm actually blocked from upgrading to 2.0.12+ due to something related). @botandrose thoughts on pulling in those recent changes to Turbo? I'm also happy to throw together a PR.

[botandrose]

@htcarr3 hi Thomas. Yes, I'm getting ready to release a v0.7.4 which should be the last v0.7.x release, and fixes all known bugs. There's just one last pernicious bug I'm trying to nail down first. Once v0.7.4 is out the door, I'll open a PR here to upgrade Turbo to it.

[htcarr3]

@htcarr3 hi Thomas. Yes, I'm getting ready to release a v0.7.4 which should be the last v0.7.x release, and fixes all known bugs. There's just one last pernicious bug I'm trying to nail down first. Once v0.7.4 is out the door, I'll open a PR here to upgrade Turbo to it.

Amazing! Thank you 🙏

[AlphonseSantoro]

@botandrose Do you have an estimate on when you plan to release the fix?

[botandrose]

Hi @AlphonseSantoro one month later I'm still trying to capture that bug. I think I should probably just release without it, at this point. I'll post back here when I do

[botandrose]

@AlphonseSantoro https://github.com/bigskysoftware/idiomorph/releases/tag/v0.7.4

[htcarr3]

@botandrose amazing! Can we cut a new minor version of turbo with the idiomorph version bump?

[botandrose]

@htcarr3 Unfortunately, that's not up to me. But you could create a PR that bumps idiomorph and I bet they'd merge it!

[AlphonseSantoro]

Lovely, after updating our project with this new release it works perfectly 🎉