Deduplicate Registered Voters View (#122)

* fix: deduplicate registered voters using ROW_NUMBER

* fix(views): deduplicate vplu by registered_voter_id to handle relayer events

* refactor(views): remove ROW_NUMBER deduplication per performance feedback, keeping vplu fix

* fix(views): apply Elaine's feedback - remove signer fallback in vplu, deduplicate delegation_events join

Author: atomauro

sql_files/views/registered_voters.sql

@@ -101,35 +101,39 @@ receipt_actions_prep AS (
 )
 /* Sourcing Latest Voting Power from Locks + Unlocks */ 
 , voting_power_from_locks_unlocks AS (
-  SELECT DISTINCT ON (rap.signer_account_id)
-    rap.block_timestamp
-    , rap.receipt_id
-    -- same semantics as before (prefer account_id from logs, fall back to signer)
-    , COALESCE(
-       	CASE
-        	WHEN (safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) ->> 'error') IS NULL
-        	THEN (safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) -> 'data' -> 0 ->> 'account_id')
-        	ELSE NULL
-        	END,
-      		rap.signer_account_id
-    	) AS registered_voter_id
-    , CASE
-    	WHEN (safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) ->> 'error') IS NULL
-       	THEN ((safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) -> 'data' -> 0 ->> 'locked_near_balance'))::NUMERIC
-       	ELSE NULL
-      	END AS voting_power_from_locks_unlocks
-    , CASE
-       	WHEN (safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) ->> 'error') IS NULL
-       	THEN ((safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) -> 'data' -> 0 ->> 'timestamp'))::NUMERIC
-       	ELSE NULL
-      	END AS lockup_update_at_ns
-  FROM receipt_actions_prep AS rap
-  WHERE
-      rap.method_name = 'on_lockup_update'
+  SELECT DISTINCT ON (vplu_prep.registered_voter_id)
+      vplu_prep.block_timestamp
+      , vplu_prep.receipt_id
+      , vplu_prep.registered_voter_id
+      , vplu_prep.voting_power_from_locks_unlocks
+      , vplu_prep.lockup_update_at_ns
+  FROM (
+  	SELECT 
+    		rap.block_timestamp
+    		, rap.receipt_id
+    		, CASE
+        			WHEN (safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) ->> 'error') IS NULL
+        			THEN (safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) -> 'data' -> 0 ->> 'account_id')
+        			ELSE NULL
+        			END AS registered_voter_id
+    		, CASE
+    			WHEN (safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) ->> 'error') IS NULL
+       			THEN ((safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) -> 'data' -> 0 ->> 'locked_near_balance'))::NUMERIC
+       			ELSE NULL
+      			END AS voting_power_from_locks_unlocks
+    		, CASE
+       			WHEN (safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) ->> 'error') IS NULL
+       			THEN ((safe_json_parse(REPLACE(rap.action_logs[1], 'EVENT_JSON:', '')) -> 'data' -> 0 ->> 'timestamp'))::NUMERIC
+       			ELSE NULL
+      			END AS lockup_update_at_ns
+  		FROM receipt_actions_prep AS rap
+  		WHERE
+      		rap.method_name = 'on_lockup_update' 
+	) AS vplu_prep
   ORDER BY
-      rap.signer_account_id            -- DISTINCT ON key
-      , rap.block_timestamp DESC       -- "latest" first
-      , rap.receipt_id DESC            -- deterministic tie-breaker
+      vplu_prep.registered_voter_id
+      , vplu_prep.block_timestamp DESC
+      , vplu_prep.receipt_id DESC
 )
 /* Sourcing Registered Voters from Deploy Lockup Event (Excluding dupes due to account already being registered) */
   --Whenever a user registers to vote, there should always be a non-null storage deposit, aka, initial voting power amount.
@@ -236,7 +240,16 @@ receipt_actions_prep AS (
 		ON ra.signer_account_id = vplu.registered_voter_id	
 	LEFT JOIN proposal_participation AS pp
 		ON ra.signer_account_id = pp.registered_voter_id 
-	LEFT JOIN {SCHEMA_NAME}.delegation_events AS de 
+	LEFT JOIN 
+			(
+			SELECT DISTINCT ON (delegator_id)
+				  d.* 
+			FROM {SCHEMA_NAME}.delegation_events AS d
+			ORDER BY 
+				d.delegator_id
+				, d.block_timestamp DESC
+				, d.receipt_id DESC
+			) AS de 
 	 	ON ra.signer_account_id = de.delegator_id 
 		AND de.is_latest_delegator_event = TRUE 
 		AND de.delegate_method = 'delegate_all'