fix: remove credentials support to resolve CI YAML validation error

Co-authored-by: neilime <[email protected]>

Author: Copilot

.github/workflows/continuous-integration.md

@@ -207,10 +207,7 @@ container: |
     "env": {
       "NODE_ENV": "production"
     },
-    "options": "--cpus 2",
-    "credentials": {
-      "username": "myusername"
-    }
+    "options": "--cpus 2"
   }
 ```
 
@@ -219,29 +216,8 @@ container: |
 - `image` (string, required) - Container image name
 - `env` (object) - Environment variables
 - `options` (string) - Additional Docker options
-- `credentials` (object) - Registry credentials with `username` property
 
-**Note:** `ports` and `volumes` are not currently supported due to GitHub Actions workflow syntax limitations.
-
-#### Container Registry Credentials
-
-For private container images, specify the username in the container input's `credentials.username` property and pass the password via the `container-registry-password` secret:
-
-```yaml
-jobs:
-  continuous-integration:
-    uses: hoverkraft-tech/ci-github-nodejs/.github/workflows/continuous-integration.yml@main
-    secrets:
-      container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}
-    with:
-      container: |
-        {
-          "image": "ghcr.io/myorg/my-private-image:latest",
-          "credentials": {
-            "username": "myusername"
-          }
-        }
-```
+**Note:** `ports`, `volumes`, and `credentials` are not currently supported due to GitHub Actions workflow syntax limitations.
 
 See [GitHub's container specification](https://docs.github.com/en/actions/how-tos/write-workflows/choose-where-workflows-run/run-jobs-in-a-container) for more details.
 
@@ -251,14 +227,12 @@ When specified, steps will execute inside this container instead of checking out
 
 ## Secrets
 
-| **Secret**                        | **Description**                                                                                                                          | **Required** |
-| --------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------- | ------------ |
-| **`build-secrets`**               | Secrets to be used during the build step.                                                                                                | **false**    |
-|                                   | Must be a multi-line env formatted string.                                                                                               |              |
-|                                   | Example:                                                                                                                                 |              |
-|                                   | <!-- textlint-disable --><pre lang="txt">SECRET_EXAMPLE=$\{{ secrets.SECRET_EXAMPLE }}</pre><!-- textlint-enable -->                     |              |
-| **`container-registry-password`** | Password or token for authenticating to the container registry.                                                                          | **false**    |
-|                                   | Required when using private container images. The username should be specified in the container input's `credentials.username` property. |              |
+| **Secret**          | **Description**                                                                                                      | **Required** |
+| ------------------- | -------------------------------------------------------------------------------------------------------------------- | ------------ |
+| **`build-secrets`** | Secrets to be used during the build step.                                                                            | **false**    |
+|                     | Must be a multi-line env formatted string.                                                                           |              |
+|                     | Example:                                                                                                             |              |
+|                     | <!-- textlint-disable --><pre lang="txt">SECRET_EXAMPLE=$\{{ secrets.SECRET_EXAMPLE }}</pre><!-- textlint-enable --> |              |
 
 <!-- secrets:end -->
 
@@ -390,19 +364,14 @@ jobs:
       id-token: write
       security-events: write
       contents: read
-    secrets:
-      container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}
     with:
       container: |
         {
-          "image": "ghcr.io/myorg/node-image:18-alpine",
+          "image": "node:18-alpine",
           "env": {
             "NODE_ENV": "production",
             "CI": "true"
           },
-          "credentials": {
-            "username": "myusername"
-          },
           "options": "--cpus 2 --memory 4g"
         }
       # When using container mode, code-ql and dependency-review are typically disabled

.github/workflows/continuous-integration.yml

@@ -104,10 +104,7 @@ on:
           ```
 
           Supported properties: image (required), env (object), options (string).
-          Note: ports and volumes are not currently supported due to GitHub Actions limitations.
-
-          For container registry credentials (username/password), use the container-registry-username 
-          and container-registry-password secrets.
+          Note: ports, volumes, and credentials are not currently supported due to GitHub Actions limitations.
 
           See https://docs.github.com/en/actions/how-tos/write-workflows/choose-where-workflows-run/run-jobs-in-a-container
 
@@ -126,12 +123,6 @@ on:
           SECRET_EXAMPLE=$\{{ secrets.SECRET_EXAMPLE }}
           ```
         required: false
-      container-registry-password:
-        description: |
-          Password or token for authenticating to the container registry.
-          Required when using private container images.
-          The username should be specified in the container input's credentials.username property.
-        required: false
     outputs:
       build-artifact-id:
         description: "ID of the build artifact) uploaded during the build step."
@@ -176,13 +167,6 @@ jobs:
                   config.env = container.env;
                 }
                 
-                // Add credentials username if provided
-                if (container.credentials && container.credentials.username) {
-                  config.credentials = {
-                    username: container.credentials.username
-                  };
-                }
-                
                 // Merge user options with default --user root:root
                 if (container.options) {
                   config.options = `${config.options} ${container.options}`;
@@ -228,9 +212,6 @@ jobs:
       image: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).image || null }}
       env: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).env || null }}
       options: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).options || null }}
-      credentials:
-        username: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).credentials.username || null }}
-        password: ${{ secrets.container-registry-password }}
     needs: parse-container
     if: ${{ always() && !cancelled() && !failure() }}
     permissions:
@@ -352,9 +333,6 @@ jobs:
       image: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).image || null }}
       env: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).env || null }}
       options: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).options || null }}
-      credentials:
-        username: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).credentials.username || null }}
-        password: ${{ secrets.container-registry-password }}
     needs:
       - parse-container
       - setup
@@ -414,9 +392,6 @@ jobs:
       image: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).image || null }}
       env: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).env || null }}
       options: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).options || null }}
-      credentials:
-        username: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).credentials.username || null }}
-        password: ${{ secrets.container-registry-password }}
     needs:
       - parse-container
       - setup
@@ -466,9 +441,6 @@ jobs:
       image: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).image || null }}
       env: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).env || null }}
       options: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).options || null }}
-      credentials:
-        username: ${{ inputs.container != '' && fromJSON(needs.parse-container.outputs.config).credentials.username || null }}
-        password: ${{ secrets.container-registry-password }}
     needs:
       - parse-container
       - setup