Use @actions/exec instead of child_process and add auto-detection

Copilot · neilime · Copilot · commit 90dd79cf357d · 2025-11-12T12:27:35.000Z
- Replace child_process with @actions/exec package
- Use exec.getExecOutput for better error handling
- Use node:path instead of path
- Add auto-detection for lint report files (eslint-report.json, checkstyle.xml, etc.)
- Add auto-detection for coverage files (cobertura-coverage.xml, lcov.info, etc.)
- Update documentation to reflect auto-detection capabilities

Co-authored-by: neilime &lt;314088+neilime@users.noreply.github.com&gt;
diff --git a/actions/build/action.yml b/actions/build/action.yml
@@ -110,10 +110,8 @@ runs:
         WORKING_DIRECTORY: ${{ inputs.working-directory }}
       with:
         script: |
-          const { exec } = require('child_process');
-          const { promisify } = require('util');
-          const execAsync = promisify(exec);
-          const path = require('path');
+          const path = require('node:path');
+          const exec = require('@actions/exec');
 
           const buildCommands = process.env.BUILD_COMMANDS || '';
           const runScriptCommand = process.env.RUN_SCRIPT_COMMAND;
@@ -127,16 +125,14 @@ runs:
             core.info(`\n🏗️ Running build command: ${command}`);
             
             try {
-              const { stdout, stderr } = await execAsync(`${runScriptCommand} ${command}`, {
+              const result = await exec.getExecOutput(runScriptCommand, [command], {
                 cwd: path.resolve(process.env.GITHUB_WORKSPACE, workingDirectory)
               });
               
-              if (stdout) core.info(stdout);
-              if (stderr) core.warning(stderr);
+              if (result.stdout) core.info(result.stdout);
+              if (result.stderr) core.warning(result.stderr);
             } catch (error) {
-              if (error.stdout) core.info(error.stdout);
-              if (error.stderr) core.error(error.stderr);
-              core.setFailed(`Build command "${command}" failed with exit code ${error.code || 1}`);
+              core.setFailed(`Build command "${command}" failed: ${error.message}`);
               throw error;
             }
           }
diff --git a/actions/lint/action.yml b/actions/lint/action.yml
@@ -20,7 +20,9 @@ inputs:
     description: |
       Path to lint report file to process as GitHub annotations.
       Supports ESLint JSON and Checkstyle XML formats.
-      If not specified, no report processing is done.
+      If not specified, auto-detection will be attempted for common paths:
+      - eslint-report.json, eslint.json
+      - checkstyle-result.xml, checkstyle.xml
     required: false
     default: ""
   report-format:
@@ -67,10 +69,8 @@ runs:
         FAIL_ON_ERROR: ${{ inputs.fail-on-error }}
       with:
         script: |
-          const { exec } = require('child_process');
-          const { promisify } = require('util');
-          const execAsync = promisify(exec);
-          const path = require('path');
+          const path = require('node:path');
+          const exec = require('@actions/exec');
 
           const workingDirectory = process.env.WORKING_DIRECTORY || '.';
           const runScriptCommand = process.env.RUN_SCRIPT_COMMAND;
@@ -79,42 +79,87 @@ runs:
           core.info('👕 Running lint...');
 
           try {
-            const { stdout, stderr } = await execAsync(`${runScriptCommand} lint`, {
-              cwd: path.resolve(process.env.GITHUB_WORKSPACE, workingDirectory)
+            const result = await exec.getExecOutput(runScriptCommand, ['lint'], {
+              cwd: path.resolve(process.env.GITHUB_WORKSPACE, workingDirectory),
+              ignoreReturnCode: true
             });
             
-            if (stdout) core.info(stdout);
-            if (stderr) core.warning(stderr);
+            if (result.stdout) core.info(result.stdout);
+            if (result.stderr) core.warning(result.stderr);
             
-            core.setOutput('lint-exit-code', 0);
-          } catch (error) {
-            core.setOutput('lint-exit-code', error.code || 1);
-            
-            if (error.stdout) core.info(error.stdout);
-            if (error.stderr) core.error(error.stderr);
+            core.setOutput('lint-exit-code', result.exitCode);
             
-            if (failOnError) {
-              core.setFailed(`Linting failed with exit code ${error.code || 1}`);
-            } else {
-              core.warning(`Linting failed with exit code ${error.code || 1}`);
+            if (result.exitCode !== 0 && failOnError) {
+              core.setFailed(`Linting failed with exit code ${result.exitCode}`);
+            } else if (result.exitCode !== 0) {
+              core.warning(`Linting failed with exit code ${result.exitCode}`);
             }
+          } catch (error) {
+            core.setOutput('lint-exit-code', 1);
+            core.setFailed(`Linting error: ${error.message}`);
           }
     # jscpd:ignore-end
+    # Auto-detect report file if not specified
+    - id: detect-report-file
+      if: always() && inputs.report-file == ''
+      uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
+      env:
+        WORKING_DIRECTORY: ${{ inputs.working-directory }}
+      with:
+        script: |
+          const fs = require('node:fs');
+          const path = require('node:path');
+
+          const workingDirectory = process.env.WORKING_DIRECTORY || '.';
+          const workDir = path.resolve(process.env.GITHUB_WORKSPACE, workingDirectory);
+
+          // Common lint report file paths
+          const commonPaths = [
+            'eslint-report.json',
+            'eslint.json',
+            '.eslint-report.json',
+            'checkstyle-result.xml',
+            'checkstyle.xml',
+            'lint-results.xml',
+            'reports/eslint-report.json',
+            'reports/checkstyle.xml'
+          ];
+
+          for (const filePath of commonPaths) {
+            const fullPath = path.join(workDir, filePath);
+            if (fs.existsSync(fullPath)) {
+              core.info(`Auto-detected lint report file: ${filePath}`);
+              core.setOutput('report-file', filePath);
+              
+              // Auto-detect format from extension
+              if (filePath.endsWith('.json')) {
+                core.setOutput('report-format', 'eslint');
+              } else if (filePath.endsWith('.xml')) {
+                core.setOutput('report-format', 'checkstyle');
+              }
+              return;
+            }
+          }
+
+          core.info('No lint report file auto-detected');
+          core.setOutput('report-file', '');
+          core.setOutput('report-format', '');
+
     # Process ESLint report
     - name: 📊 Annotate ESLint results
-      if: always() && inputs.report-file != '' && (inputs.report-format == 'eslint' || inputs.report-format == '')
+      if: always() && (inputs.report-file != '' || steps.detect-report-file.outputs.report-file != '') && (inputs.report-format == 'eslint' || steps.detect-report-file.outputs.report-format == 'eslint' || (inputs.report-format == '' && steps.detect-report-file.outputs.report-format == ''))
       uses: ataylorme/eslint-annotate-action@d57a1193d4c59cbfbf2f1529e82e2f8e0da1498d # v3.0.0
       with:
-        report-json: ${{ inputs.working-directory }}/${{ inputs.report-file }}
+        report-json: ${{ inputs.working-directory }}/${{ inputs.report-file != '' && inputs.report-file || steps.detect-report-file.outputs.report-file }}
         fail-on-error: false
         fail-on-warning: false
 
     # Process Checkstyle report
     - name: 📊 Annotate Checkstyle results
-      if: always() && inputs.report-file != '' && inputs.report-format == 'checkstyle'
+      if: always() && (inputs.report-file != '' || steps.detect-report-file.outputs.report-file != '') && (inputs.report-format == 'checkstyle' || steps.detect-report-file.outputs.report-format == 'checkstyle')
       uses: lcollins/checkstyle-github-action@8e0abb97e71a72c2cf9d6f0619e38002cb6e36c9 # v2.0.0
       with:
-        path: ${{ inputs.working-directory }}/${{ inputs.report-file }}
+        path: ${{ inputs.working-directory }}/${{ inputs.report-file != '' && inputs.report-file || steps.detect-report-file.outputs.report-file }}
 
     - shell: bash
       if: always() && steps.run-lint.outputs.lint-exit-code != '0' && inputs.fail-on-error == 'true'
diff --git a/actions/test/action.yml b/actions/test/action.yml
@@ -29,8 +29,12 @@ inputs:
       Path to coverage files for reporting.
       Supports multiple formats (Cobertura, OpenCover, lcov, etc.).
       Can be a single file or multiple files separated by semicolons.
+      If not specified, auto-detection will be attempted for common paths:
+      - coverage/cobertura-coverage.xml, coverage/coverage.xml
+      - coverage/lcov.info
+      - coverage/clover.xml
     required: false
-    default: "coverage/cobertura-coverage.xml"
+    default: ""
   codecov-token:
     description: |
       Codecov token for private repositories.
@@ -84,10 +88,8 @@ runs:
         FAIL_ON_ERROR: ${{ inputs.fail-on-error }}
       with:
         script: |
-          const { exec } = require('child_process');
-          const { promisify } = require('util');
-          const execAsync = promisify(exec);
-          const path = require('path');
+          const path = require('node:path');
+          const exec = require('@actions/exec');
 
           const workingDirectory = process.env.WORKING_DIRECTORY || '.';
           const runScriptCommand = process.env.RUN_SCRIPT_COMMAND;
@@ -96,26 +98,25 @@ runs:
           core.info('🧪 Running tests...');
 
           try {
-            const { stdout, stderr } = await execAsync(`${runScriptCommand} test:ci`, {
+            const result = await exec.getExecOutput(runScriptCommand, ['test:ci'], {
               cwd: path.resolve(process.env.GITHUB_WORKSPACE, workingDirectory),
-              env: { ...process.env, CI: 'true' }
+              env: { ...process.env, CI: 'true' },
+              ignoreReturnCode: true
             });
             
-            if (stdout) core.info(stdout);
-            if (stderr) core.warning(stderr);
-            
-            core.setOutput('test-exit-code', 0);
-          } catch (error) {
-            core.setOutput('test-exit-code', error.code || 1);
+            if (result.stdout) core.info(result.stdout);
+            if (result.stderr) core.warning(result.stderr);
             
-            if (error.stdout) core.info(error.stdout);
-            if (error.stderr) core.error(error.stderr);
+            core.setOutput('test-exit-code', result.exitCode);
             
-            if (failOnError) {
-              core.setFailed(`Tests failed with exit code ${error.code || 1}`);
-            } else {
-              core.warning(`Tests failed with exit code ${error.code || 1}`);
+            if (result.exitCode !== 0 && failOnError) {
+              core.setFailed(`Tests failed with exit code ${result.exitCode}`);
+            } else if (result.exitCode !== 0) {
+              core.warning(`Tests failed with exit code ${result.exitCode}`);
             }
+          } catch (error) {
+            core.setOutput('test-exit-code', 1);
+            core.setFailed(`Test execution error: ${error.message}`);
           }
     # jscpd:ignore-end
     # Install dependencies for codecov in container mode
@@ -134,6 +135,43 @@ runs:
           fi
         done
 
+    # Auto-detect coverage files if not specified
+    - id: detect-coverage-files
+      if: always() && inputs.coverage == 'github' && inputs.coverage-files == ''
+      uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
+      env:
+        WORKING_DIRECTORY: ${{ inputs.working-directory }}
+      with:
+        script: |
+          const fs = require('node:fs');
+          const path = require('node:path');
+
+          const workingDirectory = process.env.WORKING_DIRECTORY || '.';
+          const workDir = path.resolve(process.env.GITHUB_WORKSPACE, workingDirectory);
+
+          // Common coverage file paths
+          const commonPaths = [
+            'coverage/cobertura-coverage.xml',
+            'coverage/coverage.xml',
+            'coverage/lcov.info',
+            'coverage/clover.xml',
+            'coverage/coverage-final.json',
+            'test-results/coverage.xml',
+            'test-results/cobertura-coverage.xml'
+          ];
+
+          for (const filePath of commonPaths) {
+            const fullPath = path.join(workDir, filePath);
+            if (fs.existsSync(fullPath)) {
+              core.info(`Auto-detected coverage file: ${filePath}`);
+              core.setOutput('coverage-files', filePath);
+              return;
+            }
+          }
+
+          core.warning('No coverage file auto-detected');
+          core.setOutput('coverage-files', 'coverage/cobertura-coverage.xml');
+
     # Upload to Codecov
     - name: 📊 Upload coverage to Codecov
       if: always() && inputs.coverage == 'codecov'
@@ -150,7 +188,7 @@ runs:
       if: always() && inputs.coverage == 'github' && github.event_name == 'pull_request'
       uses: danielpalme/ReportGenerator-GitHub-Action@d78d7a99ab2e53f4fa9e37c558feb9cd6a7a1c70 # v5.4.3
       with:
-        reports: ${{ inputs.coverage-files }}
+        reports: ${{ inputs.coverage-files != '' && inputs.coverage-files || steps.detect-coverage-files.outputs.coverage-files }}
         targetdir: coveragereport
         reporttypes: MarkdownSummaryGithub
         sourcedirs: ${{ inputs.working-directory }}
