fix: make the action really works

Author: fredleger

.d.ts

@@ -0,0 +1 @@
+declare module 'ovh';

.gitignore

@@ -1,3 +1,6 @@
+# direnv
+.envrc
+
 # Logs
 logs
 *.log

README.md

@@ -1,2 +1,11 @@
 # github-action-ovh-mks-scaling
+
 Scale up or down a OVH MKS nodepool
+
+You need first to :
+
+- create an application in OVH api at : https://www.ovh.com/auth/api/createApp
+- export env vars `OVH_APPLICATION_KEY` and `OVH_APPLICATION_SECRET`
+- and to run the script `scripts/create-ovh-creds.sh`
+- note the consumer key
+- click on the link for credentials validation

action.yml

@@ -9,10 +9,6 @@ inputs:
     required: true
     description: 'The OVH endpoint to use'
     default: 'eu.api.ovh.com'
-  region:
-    required: true
-    description: 'The OVH region to use'
-    default: 'GRA'
   project_id:
     required: true
     description: 'The project ID of the OVH MKS project'

index.js

@@ -1,33 +1,65 @@
-import { getInput, setOutput, setFailed } from '@actions/core';
-import { readFile } from 'node:fs/promises';
-import ovh from 'ovh';
+import { getInput, setOutput, setFailed } from "@actions/core";
+import ovh from "ovh";
 
-try {
-  const ovhEndpoint = getInput('endpoint');
-  const ovhRegion = getInput('region');
-  const ovhProjectId = getInput('project_id');
-  const ovhClusterId = getInput('cluster_id');
-  const ovhNodepoolId = getInput('nodepool_id');
-  const nodesNumber = getInput('number_of_nodes');
+const ovhEndpoint = getInput("endpoint");
+const ovhProjectId = getInput("project_id");
+const ovhClusterId = getInput("cluster_id");
+const ovhNodepoolId = getInput("nodepool_id");
+const nodesNumber = getInput("number_of_nodes");
+
+// setup OVH api client
+const client = ovh({
+  endpoint: ovhEndpoint,
+  appKey: process.env.OVH_APPLICATION_KEY,
+  appSecret: process.env.OVH_APPLICATION_SECRET,
+  consumerKey: process.env.OVH_CONSUMER_KEY,
+});
 
-  // setup OVH api client
-	const client = ovh({
-    endpoint: ovhEndpoint,
-		appKey: process.env.OVH_APP_KEY,
-		appSecret: process.env.OVH_APP_SECRET,
-		consumerKey: process.env.OVH_CONSUMER_KEY,
-	});
+// Call the OVH API to scale the nodepool
+// see https://eu.api.ovh.com/console/?section=%2Fcloud&branch=v1#put-/cloud/project/-serviceName-/kube/-kubeId-/nodepool/-nodePoolId-
+// curl -X PUT "https://eu.api.ovh.com/v1/cloud/project//kube//nodepool/" \
+//   -H "content-type: application/json" \
+//   -d '{"autoscale":false,"autoscaling":{"scaleDownUnneededTimeSeconds":0,"scaleDownUnreadyTimeSeconds":0,"scaleDownUtilizationThreshold":0},"desiredNodes":0,"maxNodes":0,"minNodes":0,"nodesToRemove":["string"],"template":{"metadata":{"annotations":{"any-key":"string"},"finalizers":["string"],"labels":{"any-key":"string"}},"spec":{"taints":[{"effect":"NoExecute","key":"string","value":"string"}],"unschedulable":false}}}' \
 
-  // Call the OVH API to scale the nodepool
-  // see https://eu.api.ovh.com/console/?section=%2Fcloud&branch=v1#put-/cloud/project/-serviceName-/kube/-kubeId-/nodepool/-nodePoolId-
-  // curl -X PUT "https://eu.api.ovh.com/v1/cloud/project//kube//nodepool/" \
- //   -H "content-type: application/json" \
- //   -d '{"autoscale":false,"autoscaling":{"scaleDownUnneededTimeSeconds":0,"scaleDownUnreadyTimeSeconds":0,"scaleDownUtilizationThreshold":0},"desiredNodes":0,"maxNodes":0,"minNodes":0,"nodesToRemove":["string"],"template":{"metadata":{"annotations":{"any-key":"string"},"finalizers":["string"],"labels":{"any-key":"string"}},"spec":{"taints":[{"effect":"NoExecute","key":"string","value":"string"}],"unschedulable":false}}}' \
+console.log("Scaling nodepool with the following parameters:", {
+  endpoint: ovhEndpoint,
+  projectId: ovhProjectId,
+  clusterId: ovhClusterId,
+  nodepoolId: ovhNodepoolId,
+  desiredNodes: parseInt(nodesNumber),
+  url: `/cloud/project/${ovhProjectId}/kube/${ovhClusterId}/nodepool/${ovhNodepoolId}`,
+  method: "PUT",
+  body: {
+    autoscale: false,
+    autoscaling: {},
+    minNodes: parseInt(nodesNumber),
+    maxNodes: parseInt(nodesNumber),
+    desiredNodes: parseInt(nodesNumber),
+  },
+});
+
+let response;
+try {
+  response = await client.requestPromised(
+    "PUT",
+    `/cloud/project/${ovhProjectId}/kube/${ovhClusterId}/nodepool/${ovhNodepoolId}`,
+    {
+      autoscale: false,
+      autoscaling: {},
+      minNodes: parseInt(nodesNumber),
+      maxNodes: parseInt(nodesNumber),
+      desiredNodes: parseInt(nodesNumber),
+    }
+  );
 
-  const response = await client.requestPromised('PUT', `/v1/cloud/project/${ovhProjectId}/kube/${ovhClusterId}/nodepool/${ovhNodepoolId}`, {
-    "desiredNodes": nodesNumber,
-  });
-	setOutput("response", response)
+  console.log("OVH API response:", response.code);
+  setOutput("response", response);
 } catch (err) {
-	setFailed(err.message)
+  // Handle OVH API 204 No Content as success
+  if (err && err.error === 204) {
+    console.log("OVH API returned 204 No Content (success)");
+    setOutput("response", { code: 204, message: "No Content (success)" });
+  } else {
+    setFailed(`Action error: ${err && err.message ? err.message : JSON.stringify(err)}`);
+  }
 }

package.json

@@ -3,6 +3,7 @@
   "version": "1.0.0",
   "description": "Scale up or down your OVH MKS nodepool",
   "main": "index.js",
+  "type": "module",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"
   },

scripts/create-ovh-creds.sh

@@ -0,0 +1,20 @@
+#!/bin/bash
+
+set -euo pipefail
+
+set -x
+
+if [ -z "${OVH_APPLICATION_KEY}" ]; then
+  echo "OVH_APPLICATION_KEY is not set"
+  exit 1
+fi
+
+curl -XPOST -H "X-Ovh-Application: ${OVH_APPLICATION_KEY}" -H "Content-type: application/json" https://eu.api.ovh.com/1.0/auth/credential -d '{
+  "accessRules": [
+    {
+      "method": "PUT",
+      "path": "/cloud/project/*/kube/*/nodepool/*"
+    }
+  ],
+  "redirection": "https://hoverkraft.cloud"
+}' | jq