escapeshellarg

howtomakeaturn · howtomakeaturn · commit 12410665342b · 2015-03-21T20:58:47.000+08:00
diff --git a/src/Howtomakeaturn/PDFInfo/PDFInfo.php b/src/Howtomakeaturn/PDFInfo/PDFInfo.php
@@ -39,10 +39,10 @@ public function loadOutput()
     {
         $cmd = "pdfinfo";           // Linux
 
-        $file = $this->file;
+        $file = escapeshellarg($this->file);
         // Parse entire output
         // Surround with double quotes if file name has spaces
-        exec("$cmd \"$file\"", $output);
+        exec("$cmd $file", $output);
         
         $this->output = $output;
     }

Original file line number	Diff line number	Diff line change
`@@ -39,10 +39,10 @@ public function loadOutput()`
`39`	`39`	`{`
`40`	`40`	`$cmd = "pdfinfo"; // Linux`
`41`	`41`
`42`		`- $file = $this->file;`
	`42`	`+ $file = escapeshellarg($this->file);`
`43`	`43`	`// Parse entire output`
`44`	`44`	`// Surround with double quotes if file name has spaces`
`45`		`- exec("$cmd \"$file\"", $output);`
	`45`	`+ exec("$cmd $file", $output);`
`46`	`46`
`47`	`47`	`$this->output = $output;`
`48`	`48`	`}`