Skip to content

Commit 10d0d99

Browse files
hoxyqmeta-codesync[bot]
authored andcommitted
Move TracingState interfaces to inspector package (facebook#54632)
Summary: Pull Request resolved: facebook#54632 # Changelog: [Internal] Tracing is a concept of Inspector. It should be part of the Inspector package, not general interfaces. The Inspector stack is the only mechanism that controls the tracing state of a Host. Reviewed By: cortinico Differential Revision: D87638583 fbshipit-source-id: 2c065dc0d57914fa49c64fd7dc8e24091b3f42d8
1 parent 58ec261 commit 10d0d99

File tree

13 files changed

+17
-17
lines changed

13 files changed

+17
-17
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BridgelessDevSupportManager.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ package com.facebook.react.devsupport
1010
import android.content.Context
1111
import com.facebook.react.bridge.UiThreadUtil
1212
import com.facebook.react.common.SurfaceDelegateFactory
13+
import com.facebook.react.devsupport.inspector.TracingState
1314
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener
1415
import com.facebook.react.devsupport.interfaces.DevLoadingViewManager
1516
import com.facebook.react.devsupport.interfaces.DevSupportManager
1617
import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager
1718
import com.facebook.react.devsupport.interfaces.RedBoxHandler
18-
import com.facebook.react.devsupport.interfaces.TracingState
1919
import com.facebook.react.packagerconnection.RequestHandler
2020

2121
/**

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ import com.facebook.react.devsupport.DevServerHelper.PackagerCommandListener
5252
import com.facebook.react.devsupport.InspectorFlags.getFuseboxEnabled
5353
import com.facebook.react.devsupport.StackTraceHelper.convertJavaStackTrace
5454
import com.facebook.react.devsupport.StackTraceHelper.convertJsStackTrace
55+
import com.facebook.react.devsupport.inspector.TracingState
56+
import com.facebook.react.devsupport.inspector.TracingStateProvider
5557
import com.facebook.react.devsupport.interfaces.BundleLoadCallback
5658
import com.facebook.react.devsupport.interfaces.DebuggerFrontendPanelName
5759
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener
@@ -66,8 +68,6 @@ import com.facebook.react.devsupport.interfaces.PackagerStatusCallback
6668
import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager
6769
import com.facebook.react.devsupport.interfaces.RedBoxHandler
6870
import com.facebook.react.devsupport.interfaces.StackFrame
69-
import com.facebook.react.devsupport.interfaces.TracingState
70-
import com.facebook.react.devsupport.interfaces.TracingStateProvider
7171
import com.facebook.react.devsupport.perfmonitor.PerfMonitorDevHelper
7272
import com.facebook.react.devsupport.perfmonitor.PerfMonitorOverlayManager
7373
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/TracingState.kt renamed to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/TracingState.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
package com.facebook.react.devsupport.interfaces
8+
package com.facebook.react.devsupport.inspector
99

1010
import com.facebook.proguard.annotations.DoNotStripAny
1111

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/TracingStateListener.kt renamed to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/TracingStateListener.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
package com.facebook.react.devsupport.interfaces
8+
package com.facebook.react.devsupport.inspector
99

1010
import com.facebook.proguard.annotations.DoNotStripAny
1111

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/TracingStateProvider.kt renamed to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/TracingStateProvider.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
package com.facebook.react.devsupport.interfaces
8+
package com.facebook.react.devsupport.inspector
99

1010
internal interface TracingStateProvider {
1111
fun getTracingState(): TracingState

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorInspectorTargetBinding.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
package com.facebook.react.devsupport.perfmonitor
99

10-
import com.facebook.react.devsupport.interfaces.TracingState
10+
import com.facebook.react.devsupport.inspector.TracingState
1111

1212
/**
1313
* [Experimental] Interface implemented by [com.facebook.react.runtime.ReactHostInspectorTarget]

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayManager.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ package com.facebook.react.devsupport.perfmonitor
1010
import android.os.Handler
1111
import android.os.Looper
1212
import com.facebook.react.bridge.UiThreadUtil
13-
import com.facebook.react.devsupport.interfaces.TracingState
13+
import com.facebook.react.devsupport.inspector.TracingState
1414

1515
internal class PerfMonitorOverlayManager(
1616
private val devHelper: PerfMonitorDevHelper,

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayView.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import android.widget.TextView
2121
import androidx.core.view.ViewCompat
2222
import androidx.core.view.WindowInsetsCompat
2323
import com.facebook.react.R
24-
import com.facebook.react.devsupport.interfaces.TracingState
24+
import com.facebook.react.devsupport.inspector.TracingState
2525
import com.facebook.react.uimanager.DisplayMetricsHolder
2626
import com.facebook.react.uimanager.PixelUtil
2727

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorUpdateListener.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
package com.facebook.react.devsupport.perfmonitor
99

10-
import com.facebook.react.devsupport.interfaces.TracingState
10+
import com.facebook.react.devsupport.inspector.TracingState
1111

1212
/** [Experimental] An interface for subscribing to updates for the V2 Perf Monitor. */
1313
internal interface PerfMonitorUpdateListener {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImplDevHelper.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ import com.facebook.react.bridge.ReactContext
1616
import com.facebook.react.common.annotations.FrameworkAPI
1717
import com.facebook.react.common.annotations.UnstableReactNativeAPI
1818
import com.facebook.react.devsupport.ReactInstanceDevHelper
19-
import com.facebook.react.devsupport.interfaces.TracingState
20-
import com.facebook.react.devsupport.interfaces.TracingStateProvider
19+
import com.facebook.react.devsupport.inspector.TracingState
20+
import com.facebook.react.devsupport.inspector.TracingStateProvider
2121
import com.facebook.react.devsupport.perfmonitor.PerfMonitorDevHelper
2222
import com.facebook.react.devsupport.perfmonitor.PerfMonitorInspectorTarget
2323
import com.facebook.react.interfaces.TaskInterface

0 commit comments

Comments
 (0)