Skip to content

Commit 571189a

Browse files
hoxyqfacebook-github-bot
authored andcommitted
Hide Performance Monitor when tracing in RNDT
Summary: # Changelog: [Internal] As titled. Before this change, monitor was just disabled, but was shown in the UI. I think we should completely hide it, so it doesn't contribute to any frames or screenshots data. Since the trace is already initialized from the RNDT, user has already expressed the intent for tracing, we don't need to show it in the UI. Differential Revision: D88748037
1 parent 7f67592 commit 571189a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayManager.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,11 @@ internal class PerfMonitorOverlayManager(
8383
UiThreadUtil.runOnUiThread {
8484
view?.updateRecordingState(state)
8585
view?.updatePerfIssueCount(perfIssueCount)
86-
view?.show()
86+
if (state == TracingState.ENABLED_IN_CDP_MODE) {
87+
view?.hide()
88+
} else {
89+
view?.show()
90+
}
8791
}
8892
}
8993

0 commit comments

Comments
 (0)