Skip to content

Commit e70bfd4

Browse files
committed
basic reads and writes work...
1 parent acb8d12 commit e70bfd4

File tree

11 files changed

+438
-212
lines changed

11 files changed

+438
-212
lines changed

compile_commands.json

Lines changed: 153 additions & 158 deletions
Large diffs are not rendered by default.

src/server/include/pdc_client_server_common.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,8 @@ typedef struct data_server_region_t {
335335
// For non-mapped object analysis
336336
// Used primarily as a local_temp
337337
void * obj_data_ptr;
338-
char * storage_location; // save the file location to enable reopening
338+
// FIXME: (Noah) we should dynamically allocate this number....
339+
char* storage_location[1024]; // save the file location to enable reopening
339340
struct data_server_region_t *prev;
340341
struct data_server_region_t *next;
341342
} data_server_region_t;

src/server/pdc_client_server_common.c

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1214,6 +1214,11 @@ PDC_Server_release_lock_request(uint64_t obj_id ATTRIBUTE(unused)
12141214
{
12151215
return SUCCEED;
12161216
}
1217+
perr_t PDC_Server_data_write_out_region_per_file(uint64_t obj_id,
1218+
struct pdc_region_info *region_info, void *buf, size_t unit)
1219+
{
1220+
return SUCCEED;
1221+
}
12171222
perr_t
12181223
PDC_Server_data_write_out(uint64_t obj_id ATTRIBUTE(unused),
12191224
struct pdc_region_info *region_info ATTRIBUTE(unused), void *buf ATTRIBUTE(unused),
@@ -1222,6 +1227,13 @@ PDC_Server_data_write_out(uint64_t obj_id ATTRIBUTE(unused),
12221227
return SUCCEED;
12231228
}
12241229
perr_t
1230+
PDC_Server_data_read_from_region_per_file(uint64_t obj_id ATTRIBUTE(unused),
1231+
struct pdc_region_info *region_info ATTRIBUTE(unused), void *buf ATTRIBUTE(unused),
1232+
size_t unit ATTRIBUTE(unused))
1233+
{
1234+
return SUCCEED;
1235+
}
1236+
perr_t
12251237
PDC_Server_data_read_from(uint64_t obj_id ATTRIBUTE(unused),
12261238
struct pdc_region_info *region_info ATTRIBUTE(unused), void *buf ATTRIBUTE(unused),
12271239
size_t unit ATTRIBUTE(unused))
@@ -1336,7 +1348,7 @@ PDC_Server_unregister_obj_region(pdcid_t obj_id ATTRIBUTE(unused))
13361348
}
13371349
perr_t
13381350
PDC_Server_register_obj_region_by_pointer(data_server_region_t **new_obj_reg ATTRIBUTE(unused),
1339-
pdcid_t obj_id ATTRIBUTE(unused), int close_flag ATTRIBUTE(unused))
1351+
pdcid_t obj_id ATTRIBUTE(unused), int close_flag ATTRIBUTE(unused), uint64_t offset ATTRIBUTE(unused))
13401352
{
13411353
return 0;
13421354
}

src/server/pdc_server.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1700,7 +1700,8 @@ PDC_Server_restart(char *filename)
17001700
data_server_region_t *new_obj_reg =
17011701
(data_server_region_t *)calloc(1, sizeof(struct data_server_region_t));
17021702
new_obj_reg->fd = -1;
1703-
new_obj_reg->storage_location = (char *)malloc(sizeof(char) * ADDR_MAX);
1703+
// FIXME: (Noah)
1704+
new_obj_reg->storage_location[0] = (char *)malloc(sizeof(char) * ADDR_MAX);
17041705
if (fread(&new_obj_reg->obj_id, sizeof(uint64_t), 1, file) != 1) {
17051706
LOG_ERROR("Read failed for obj_id\n");
17061707
}
@@ -2321,9 +2322,9 @@ server_run(int argc, char *argv[])
23212322
LOG_INFO("==PDC_SERVER[%d]: total startup time = %.6f\n", pdc_server_rank_g, server_init_time);
23222323
#endif
23232324
#ifdef ENABLE_MPI
2324-
LOG_INFO("==PDC_SERVER[%d]: Server ready!\n\n\n", pdc_server_rank_g);
2325+
LOG_INFO("==PDC_SERVER[%d]: Server ready!\n\n", pdc_server_rank_g);
23252326
#else
2326-
LOG_INFO("==PDC_SERVER[%d]: Server ready (no MPI)!\n\n\n", pdc_server_rank_g);
2327+
LOG_INFO("==PDC_SERVER[%d]: Server ready (no MPI)!\n\n", pdc_server_rank_g);
23272328
#endif
23282329
}
23292330
fflush(stdout);

src/server/pdc_server_metadata.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2685,7 +2685,8 @@ PDC_Server_get_storage_meta_by_names(query_read_names_args_t *args)
26852685
}
26862686
total_region += all_nregion[i];
26872687

2688-
if (all_storage_meta[i]->storage_location[1] != 'g') {
2688+
// FIXME: (Noah)
2689+
if (all_storage_meta[i]->storage_location[0] != 'g') {
26892690
LOG_ERROR("==PDC_SERVER[%d]: Error with storage meta for [%s], obj_id %" PRIu64
26902691
", loc [%s], offset "
26912692
"%" PRIu64 "\n",

src/server/pdc_server_region/include/pdc_server_data.h

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ data_server_region_t *PDC_Server_get_obj_region(pdcid_t obj_id);
416416
* \return SUCCEED/FAIL
417417
*/
418418
perr_t PDC_Server_register_obj_region_by_pointer(data_server_region_t **new_obj_reg, pdcid_t obj_id,
419-
int close_flag);
419+
int close_flag, uint64_t region_index);
420420
perr_t PDC_Server_register_obj_region(pdcid_t obj_id);
421421
/**
422422
* Server unregister region struct by object ID, if not existing.
@@ -469,6 +469,19 @@ hg_return_t PDC_Server_data_io_via_shm(const struct hg_cb_info *callback_info);
469469
*/
470470
hg_return_t PDC_Server_count_write_check_update_storage_meta_cb(const struct hg_cb_info *callback_info);
471471

472+
/**
473+
* Write data out to desired storage single region per file
474+
*
475+
* \param obj_id [IN] Object ID
476+
* \param region_info [IN] Region information
477+
* \param buf [IN] Data staring address
478+
* \param unit [IN] Size of data type
479+
*
480+
* \return Non-negative on success/Negative on failure
481+
*/
482+
perr_t PDC_Server_data_write_out_region_per_file(uint64_t obj_id,
483+
struct pdc_region_info *region_info, void *buf, size_t unit);
484+
472485
/**
473486
* Write data out to desired storage
474487
*
@@ -482,6 +495,20 @@ hg_return_t PDC_Server_count_write_check_update_storage_meta_cb(const struct hg_
482495
perr_t PDC_Server_data_write_out(uint64_t obj_id, struct pdc_region_info *region_info, void *buf,
483496
size_t unit);
484497

498+
/**
499+
* Read data from desired storage single region per file
500+
*
501+
* \param obj_id [IN] Object ID
502+
* \param region_info [IN] Region information
503+
* \param buf [IN] Data starting address
504+
* \param unit [IN] Size of data type
505+
*
506+
* \return Non-negative on success/Negative on failure
507+
*/
508+
perr_t
509+
PDC_Server_data_read_from_region_per_file(uint64_t obj_id, struct pdc_region_info *region_info,
510+
void *buf, size_t unit);
511+
485512
/**
486513
* Read data from desired storage
487514
*

0 commit comments

Comments
 (0)