unit tests for mirrors

Author: grodzki-lanl

stackinator/mirror.py

@@ -43,7 +43,7 @@ def _load_mirrors(self, cmdline_cache: Optional[str]) -> List[Dict]:
                 raw = yaml.load(fid, Loader=yaml.Loader)
 
             # validate the yaml
-            #schema.CacheValidator.validate(raw)
+            schema.CacheValidator.validate(raw)
 
             mirrors = [mirror for mirror in raw if mirror["enabled"]]
         else:
@@ -197,7 +197,7 @@ def _key_setup(self, key_store: pathlib.Path):
                             f"Check the key listed in mirrors.yaml in system config.")
 
                 file_type = magic.from_buffer(binary_key, mime=True)
-                print("magic type:" , file_type)
+
                 if file_type != "application/x-gnupg-keyring":
                     raise MirrorError(
                         f"Key for mirror {mirror["name"]} is not a valid GPG key. \n"

unittests/__init__.py

@@ -0,0 +1 @@
+This is a bad key

unittests/data/systems/mirror-bad-key/bad_key.gpg

@@ -0,0 +1,3 @@
+- name: bad-key
+  url: https://mirror.spack.io
+  public_key: /bad_key.gpg

unittests/data/systems/mirror-bad-key/mirrors.yaml

@@ -0,0 +1,3 @@
+- name: bad-key-path
+  url: https://mirror.spack.io
+  public_key: /path/doesnt/exist

unittests/data/systems/mirror-bad-keypath/mirrors.yaml

@@ -0,0 +1,2 @@
+- name: bad-url
+  url: google.com

unittests/data/systems/mirror-bad-url/mirrors.yaml

@@ -0,0 +1,11 @@
+- name: fake-mirror
+  url: https://google.com
+- name: disabled-mirror
+  url: https://google.com
+  enabled: false
+- name: buildcache-mirror
+  url: https://cache.spack.io/
+  buildcache: true
+- name: bootstrap-mirror
+  url: https://mirror.spack.io
+  bootstrap: true

unittests/data/systems/mirror-ok/mirrors.yaml

@@ -0,0 +1,42 @@
+import pytest
+import pathlib
+import stackinator.mirror as mirror
+import yaml
+
+@pytest.fixture
+def test_path():
+    return pathlib.Path(__file__).parent.resolve()
+
+@pytest.fixture
+def systems_path(test_path):
+    return test_path / "data" / "systems"
+
+@pytest.fixture
+def valid_mirrors(systems_path):
+    mirrors = {}
+    mirrors["fake-mirror"] = {'url': 'https://google.com'}
+    mirrors["buildcache-mirror"] = {'url': 'https://cache.spack.io/', 'buildcache': True}
+    mirrors["bootstrap-mirror"] = {'url': 'https://mirror.spack.io', 'bootstrap': True}
+    return mirrors
+
+def test_mirror_init(systems_path, valid_mirrors):
+    path = systems_path / "mirror_ok"
+    mirrors = mirror.Mirrors(path)
+    print(valid_mirrors)
+    print(mirrors)
+    assert mirrors == valid_mirrors
+    assert mirrors.bootstrap_mirrors == [mirror for mirror in valid_mirrors if mirror["bootstrap"]]
+    assert mirrors.build_cache_mirror == [mirror for mirror in valid_mirrors if mirror['buildcache']]
+    # assert disabled mirror not in mirrors
+    for mir in mirrors:
+        assert mir["enabled"]
+    # test that cmdline_cache gets added to mirrors?
+
+def test_create_spack_mirrors_yaml(systems_path):
+    pass
+
+def test_create_bootstrap_configs():
+    pass
+
+def test_key_setup():
+    pass