Skip to content

Commit f067e77

Browse files
committed
merge grpo-latest'
2 parents 5c5cb18 + cd32236 commit f067e77

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

applications/ColossalChat/coati/distributed/consumer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ def __init__(
365365
self.model = AutoModelForCausalLM.from_pretrained(path, **model_config)
366366
self.model.train()
367367
self.model.gradient_checkpointing_enable()
368-
self.optimizer = HybridAdam(self.model.parameters(), lr=1e-3)
368+
self.optimizer = HybridAdam(self.model.parameters(), lr=1e-3, weight_decay=0.01)
369369
self.accum_loss = torch.zeros(1, device=self.device)
370370

371371
def setup(self):

applications/ColossalChat/coati/distributed/grpo_consumer.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,11 @@ def __init__(
7272
self.policy_model = AutoModelForCausalLM.from_pretrained(path, **model_config)
7373
self.policy_model.train()
7474
self.policy_model.gradient_checkpointing_enable()
75-
self.optimizer = HybridAdam(self.policy_model.parameters(), lr=grpo_config.get("lr", 1e-6))
75+
self.optimizer = HybridAdam(
76+
self.policy_model.parameters(),
77+
lr=grpo_config.get("lr", 1e-6),
78+
weight_decay=grpo_config.get("weight_decay", 0.01),
79+
)
7680
self.accum_loss = torch.zeros(1, device=self.device)
7781
self.accum_kl = torch.zeros(1, device=self.device)
7882
self.accum_entropy = torch.zeros(1, device=self.device)

applications/ColossalChat/coati/distributed/reward/code_reward/testing_util.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,6 @@ def run_test(in_outs, test=None, debug=False, timeout=15, run_all_tests=False):
180180
tmp_test = new_test
181181

182182
sol += tmp_test
183-
# if debug:
184-
# print(f"sol = {sol}")
185183
method_name = "code"
186184
signal.alarm(timeout)
187185
try:

0 commit comments

Comments
 (0)