fix: check all exit codes in a loop

Author: itkovian

test/nagios.py

@@ -69,35 +69,36 @@ def test_eval(self):
     def test_cache(self):
         """Test the caching mechanism in the reporter."""
         length = random.randint(1, 30)
-        exit_code = random.randint(0, 3)
-        threshold = None
 
         message = ''.join(random.choice(string.printable) for x in range(length))
         message = message.rstrip()
 
+        threshold = None
         filename = PurePath(next(tempfile._get_candidate_names()))
 
         logging.info(f"Reporter using file {filename}")
         reporter = NagiosReporter('test_cache', filename, threshold, self.nagios_user)
 
-        nagios_exit = [NAGIOS_EXIT_OK, NAGIOS_EXIT_WARNING, NAGIOS_EXIT_CRITICAL, NAGIOS_EXIT_UNKNOWN][exit_code]
+        for exit_code in range(0, 4):
 
-        reporter.cache(nagios_exit, message)
+            nagios_exit = [NAGIOS_EXIT_OK, NAGIOS_EXIT_WARNING, NAGIOS_EXIT_CRITICAL, NAGIOS_EXIT_UNKNOWN][exit_code]
+            reporter.cache(nagios_exit, message)
 
-        old_stdout = sys.stdout
-        buffer = StringIO()
-        sys.stdout = buffer
+            old_stdout = sys.stdout
+            buffer = StringIO()
+            sys.stdout = buffer
 
-        try:
-            reporter_test = NagiosReporter('test_cache', filename, threshold, self.nagios_user)
-            reporter_test.report_and_exit()
-        except SystemExit as err:
-            line = buffer.getvalue().rstrip()
-            self.assertTrue(err.code == nagios_exit[0])
+            try:
+                reporter_test = NagiosReporter('test_cache', filename, threshold, self.nagios_user)
+                reporter_test.report_and_exit()
+            except SystemExit as err:
+                line = buffer.getvalue().rstrip()
+                logging.info("Retrieved buffer value: %s", line)
+                self.assertTrue(err.code == nagios_exit[0])
 
-        self.assertTrue(line == "%s %s" % (nagios_exit[1], message))
-        sys.stdout = old_stdout
-        buffer.close()
+            self.assertTrue(line == "%s %s" % (nagios_exit[1], message))
+            sys.stdout = old_stdout
+            buffer.close()
 
         shutil.rmtree(filename)