Skip to content

Commit 4d9fa84

Browse files
committed
refactor: simplify tab click cancel code
1 parent 1a62eb9 commit 4d9fa84

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

packages/tab/src/Tab.svelte

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
aria-selected={active ? 'true' : 'false'}
3232
tabindex={active || forceAccessible ? '0' : '-1'}
3333
{href}
34-
on:click={handleClick}
34+
on:click={(event) =>
35+
!event.defaultPrevented && instance && instance.handleClick()}
3536
{...internalAttrs}
3637
{...exclude($$restProps, ['content$', 'tabIndicator$'])}
3738
>
@@ -84,7 +85,7 @@
8485
import type { TabIndicatorComponentDev } from '@smui/tab-indicator';
8586
import TabIndicator from '@smui/tab-indicator';
8687
87-
import type { SMUITabAccessor } from './Tab.types';
88+
import type { SMUITabAccessor } from './Tab.types.js';
8889
8990
const forwardEvents = forwardEventsBuilder(get_current_component());
9091
@@ -182,12 +183,6 @@
182183
};
183184
});
184185
185-
function handleClick(event: PointerEvent) {
186-
if (!event.defaultPrevented) {
187-
instance?.handleClick();
188-
}
189-
}
190-
191186
function hasClass(className: string) {
192187
return className in internalClasses
193188
? internalClasses[className]

0 commit comments

Comments
 (0)