fix: set menu surface max height if it changes to zero after initialization

hperrin · hperrin · commit 563163a45bc4 · 2022-07-22T12:07:55.000-07:00
diff --git a/packages/menu-surface/src/MenuSurface.svelte b/packages/menu-surface/src/MenuSurface.svelte
@@ -99,7 +99,7 @@
     instance.setFixedPosition(fixed);
   }
 
-  $: if (instance && maxHeight > 0) {
+  $: if (instance) {
     instance.setMaxHeight(maxHeight);
   }
 
@@ -220,7 +220,7 @@
           'bottom' in position ? `${position.bottom}px` : '';
       },
       setMaxHeight: (height) => {
-        internalStyles["max-height"] = height;
+        internalStyles['max-height'] = height;
       },
     });
 

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@`
`99`	`99`	`instance.setFixedPosition(fixed);`
`100`	`100`	`}`
`101`	`101`
`102`		`- $: if (instance && maxHeight > 0) {`
	`102`	`+ $: if (instance) {`
`103`	`103`	`instance.setMaxHeight(maxHeight);`
`104`	`104`	`}`
`105`	`105`
`@@ -220,7 +220,7 @@`
`220`	`220`	'bottom' in position ? `${position.bottom}px` : '';
`221`	`221`	`},`
`222`	`222`	`setMaxHeight: (height) => {`
`223`		`- internalStyles["max-height"] = height;`
	`223`	`+ internalStyles['max-height'] = height;`
`224`	`224`	`},`
`225`	`225`	`});`
`226`	`226`