Skip to content

Commit dc45637

Browse files
committed
docs: fix nested accordion demo, panel accessor set check is enough
1 parent bb9e574 commit dc45637

File tree

48 files changed

+66
-75
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+66
-75
lines changed

package-lock.json

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"lerna": "^5.2.0",
4040
"prettier": "~2.7.1",
4141
"prettier-plugin-svelte": "^2.7.0",
42-
"sass": "^1.53.0",
42+
"sass": "^1.54.0",
4343
"svelte": "^3.49.0",
4444
"svelte-check": "^2.8.0"
4545
}

packages/accordion/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
},
5252
"devDependencies": {
5353
"@tsconfig/svelte": "^3.0.0",
54-
"sass": "^1.53.0",
54+
"sass": "^1.54.0",
5555
"svelte-strip": "^1.0.1",
5656
"tslib": "^2.4.0",
5757
"typescript": "^4.7.4"

packages/accordion/src/Accordion.svelte

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,19 +43,9 @@
4343
let withOpenDialog = false;
4444
4545
function handlePanelMount(event: CustomEvent<SMUIAccordionPanelAccessor>) {
46-
// To make nested accordions work, ensure event sender is a direct child of
47-
// this accordion.
48-
if (
49-
event.target &&
50-
'parentNode' in event.target &&
51-
(event.target as Element).parentNode != element
52-
) {
53-
// TODO: debug why "as Element" is necessary.
54-
return;
55-
}
56-
5746
const accessor = event.detail;
5847
48+
// Stop propagation so accordion's above this one don't receive the event.
5949
event.stopPropagation();
6050
6151
if (!multiple && accessor.open) {
@@ -79,6 +69,7 @@
7969
return;
8070
}
8171
72+
// Stop propagation so accordion's above this one don't receive the event.
8273
event.stopPropagation();
8374
8475
panelAccessorSet.delete(accessor);

packages/autocomplete/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
},
5151
"devDependencies": {
5252
"@tsconfig/svelte": "^3.0.0",
53-
"sass": "^1.53.0",
53+
"sass": "^1.54.0",
5454
"svelte-strip": "^1.0.1",
5555
"tslib": "^2.4.0",
5656
"typescript": "^4.7.4"

packages/badge/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
},
4949
"devDependencies": {
5050
"@tsconfig/svelte": "^3.0.0",
51-
"sass": "^1.53.0",
51+
"sass": "^1.54.0",
5252
"svelte-strip": "^1.0.1",
5353
"tslib": "^2.4.0",
5454
"typescript": "^4.7.4"

packages/banner/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
},
4545
"devDependencies": {
4646
"@tsconfig/svelte": "^3.0.0",
47-
"sass": "^1.53.0",
47+
"sass": "^1.54.0",
4848
"svelte-strip": "^1.0.1",
4949
"tslib": "^2.4.0",
5050
"typescript": "^4.7.4"

packages/button/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
},
5050
"devDependencies": {
5151
"@tsconfig/svelte": "^3.0.0",
52-
"sass": "^1.53.0",
52+
"sass": "^1.54.0",
5353
"svelte-strip": "^1.0.1",
5454
"tslib": "^2.4.0",
5555
"typescript": "^4.7.4"

packages/card/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"@material/button": "^13.0.0",
5050
"@material/icon-button": "^13.0.0",
5151
"@tsconfig/svelte": "^3.0.0",
52-
"sass": "^1.53.0",
52+
"sass": "^1.54.0",
5353
"svelte-strip": "^1.0.1",
5454
"tslib": "^2.4.0",
5555
"typescript": "^4.7.4"

packages/checkbox/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
},
4646
"devDependencies": {
4747
"@tsconfig/svelte": "^3.0.0",
48-
"sass": "^1.53.0",
48+
"sass": "^1.54.0",
4949
"svelte-strip": "^1.0.1",
5050
"tslib": "^2.4.0",
5151
"typescript": "^4.7.4"

0 commit comments

Comments
 (0)