BC-10862 - Add error handling for forbidden collabora access (#3974)

Author: bischofmax

src/modules/page/collabora/Collabora.page.unit.ts

@@ -1,9 +1,11 @@
 import CollaboraPage from "./Collabora.page.vue";
 import * as serverApi from "@/serverApi/v3/api";
+import { HttpStatusCode } from "@/store/types/http-status-code.enum";
 import { EditorMode } from "@/types/file/File";
 import { buildPageTitle } from "@/utils/pageTitle";
 import {
 	authorizedCollaboraDocumentUrlResponseFactory,
+	axiosErrorFactory,
 	createTestAppStoreWithUser,
 	expectNotification,
 	fileElementResponseFactory,
@@ -415,6 +417,96 @@ describe("Collabora.page", () => {
 		});
 	});
 
+	describe("when getAuthorizedCollaboraDocumentUrl rejects with 403 Forbidden", () => {
+		const setup = () => {
+			const editorMode = EditorMode.EDIT;
+
+			createTestAppStoreWithUser("user-id");
+
+			const fileStorageApiMock = createMock<ReturnType<typeof FileStorageApi.useFileStorageApi>>();
+			vi.spyOn(FileStorageApi, "useFileStorageApi").mockReturnValueOnce(fileStorageApiMock);
+			const axiosError = axiosErrorFactory.withStatusCode(HttpStatusCode.Forbidden).build();
+			fileStorageApiMock.getAuthorizedCollaboraDocumentUrl.mockRejectedValueOnce(axiosError);
+
+			const fileRecord = fileRecordFactory.build();
+			fileStorageApiMock.getFileRecordById.mockReturnValueOnce(fileRecord);
+
+			const boardApi = createMock<serverApi.BoardElementApiInterface>();
+			vi.spyOn(serverApi, "BoardElementApiFactory").mockReturnValueOnce(boardApi);
+
+			const expectedTitle = "standalone-file.pdf - Instance Title";
+			mockBuildPageTitle.mockReturnValueOnce(expectedTitle);
+
+			mount(CollaboraPage, {
+				global: {
+					plugins: [createTestingVuetify(), createTestingI18n()],
+				},
+				propsData: {
+					fileRecordId: fileRecord.id,
+					editorMode,
+				},
+			});
+
+			return {
+				fileRecord,
+				expectedTitle,
+			};
+		};
+
+		it("should call handleApplicationError with correct parameters", async () => {
+			setup();
+
+			await flushPromises();
+
+			expect(useAppStore().handleApplicationError).toHaveBeenCalledWith(HttpStatusCode.Forbidden);
+		});
+	});
+
+	describe("when getAuthorizedCollaboraDocumentUrl rejects with other error", () => {
+		const setup = () => {
+			const editorMode = EditorMode.EDIT;
+
+			createTestAppStoreWithUser("user-id");
+
+			const fileStorageApiMock = createMock<ReturnType<typeof FileStorageApi.useFileStorageApi>>();
+			vi.spyOn(FileStorageApi, "useFileStorageApi").mockReturnValueOnce(fileStorageApiMock);
+			const axiosError = axiosErrorFactory.withStatusCode(HttpStatusCode.InternalServerError).build();
+			fileStorageApiMock.getAuthorizedCollaboraDocumentUrl.mockRejectedValueOnce(axiosError);
+
+			const fileRecord = fileRecordFactory.build();
+			fileStorageApiMock.getFileRecordById.mockReturnValueOnce(fileRecord);
+
+			const boardApi = createMock<serverApi.BoardElementApiInterface>();
+			vi.spyOn(serverApi, "BoardElementApiFactory").mockReturnValueOnce(boardApi);
+
+			const expectedTitle = "standalone-file.pdf - Instance Title";
+			mockBuildPageTitle.mockReturnValueOnce(expectedTitle);
+
+			mount(CollaboraPage, {
+				global: {
+					plugins: [createTestingVuetify(), createTestingI18n()],
+				},
+				propsData: {
+					fileRecordId: fileRecord.id,
+					editorMode,
+				},
+			});
+
+			return {
+				fileRecord,
+				expectedTitle,
+			};
+		};
+
+		it("should call handleApplicationError with correct parameters", async () => {
+			setup();
+
+			await flushPromises();
+
+			expect(useAppStore().handleApplicationError).toHaveBeenCalledWith(HttpStatusCode.InternalServerError);
+		});
+	});
+
 	describe("when getElementWithParentHierarchy rejects", () => {
 		const setup = () => {
 			const editorMode = EditorMode.EDIT;

src/modules/page/collabora/Collabora.page.vue

@@ -12,8 +12,9 @@
 <script setup lang="ts">
 import { useCollaboraPostMessageApi } from "./CollaboraPostMessageApi.composable";
 import { EditorMode } from "@/types/file/File";
+import { mapAxiosErrorToResponseError } from "@/utils/api";
 import { buildPageTitle } from "@/utils/pageTitle";
-import { useAppStoreRefs } from "@data-app";
+import { useAppStore, useAppStoreRefs } from "@data-app";
 import { useBoardApi } from "@data-board";
 import { useFileStorageApi } from "@data-file";
 import { useTitle } from "@vueuse/core";
@@ -32,6 +33,7 @@ const { setupPostMessageAPI } = useCollaboraPostMessageApi();
 const { getElementWithParentHierarchyCall } = useBoardApi();
 
 const { user, locale } = useAppStoreRefs();
+const { handleApplicationError } = useAppStore();
 
 const userName = computed(() => {
 	const firstName = user.value?.firstName;
@@ -55,11 +57,9 @@ onMounted(async () => {
 });
 
 const setCollaboraUrl = async () => {
-	const responseCollaboraUrl = await getAuthorizedCollaboraDocumentUrl(
-		props.fileRecordId,
-		props.editorMode ?? EditorMode.VIEW,
-		userName.value
-	);
+	const responseCollaboraUrl = await tryGetCollaboraUrl();
+
+	if (!responseCollaboraUrl) return;
 
 	const collaboraUrl = new URL(responseCollaboraUrl);
 	collaboraUrl.searchParams.set("lang", locale.value);
@@ -83,6 +83,26 @@ const setPageTitle = async () => {
 	useTitle(pageTitle);
 };
 
+const tryGetCollaboraUrl = async (): Promise<string | undefined> => {
+	try {
+		const collaboraUrl = await getAuthorizedCollaboraDocumentUrl(
+			props.fileRecordId,
+			props.editorMode ?? EditorMode.VIEW,
+			userName.value
+		);
+
+		return collaboraUrl;
+	} catch (error) {
+		handleError(error);
+	}
+};
+
+const handleError = (error: unknown) => {
+	const responseError = mapAxiosErrorToResponseError(error);
+
+	handleApplicationError(responseError.code);
+};
+
 const getFileRecord = async (fileId: string) => {
 	let fileRecord = getFileRecordById(fileId);