BC-11196 Optimize CTL tool activation (#6062)

Author: dyedwiper

apps/server/src/modules/tool/school-external-tool/repo/mikro-orm/school-external-tool.repo.ts

@@ -87,6 +87,15 @@ export class SchoolExternalToolRepo {
 		return dos;
 	}
 
+	public async saveMany(domainObjects: SchoolExternalTool[]): Promise<void> {
+		const entities = domainObjects.map((domainObject) => {
+			const entityProps = this.mapDomainObjectToEntityProps(domainObject);
+			return new SchoolExternalToolEntity(entityProps);
+		});
+
+		await this.em.upsertMany(SchoolExternalToolEntity, entities);
+	}
+
 	private buildScope(query: SchoolExternalToolQuery): SchoolExternalToolScope {
 		const scope: SchoolExternalToolScope = new SchoolExternalToolScope();
 

apps/server/src/modules/tool/school-external-tool/service/school-external-tool.service.ts

@@ -139,27 +139,28 @@ export class SchoolExternalToolService {
 
 	public async addAndActivateToolForAllSchools(toolId: EntityId): Promise<void> {
 		const allSchoolIds = await this.schoolService.getAllSchoolIds();
-		const existingSchoolExternalTools = await this.schoolExternalToolRepo.findByExternalToolId(toolId);
 
-		existingSchoolExternalTools.forEach((tool) => tool.activate());
-		const updatePromises = existingSchoolExternalTools.map((tool) => this.schoolExternalToolRepo.save(tool));
-		await Promise.all(updatePromises);
+		const existingDeactivatedSchoolExternalTools = await this.schoolExternalToolRepo.find({
+			toolId,
+			isDeactivated: true,
+		});
+		existingDeactivatedSchoolExternalTools.forEach((tool) => tool.activate());
+		await this.schoolExternalToolRepo.saveMany(existingDeactivatedSchoolExternalTools);
 
-		const schoolIdsWhereExisting = existingSchoolExternalTools.map((tool) => tool.schoolId);
-		const schoolIdsWhereNotExisting = allSchoolIds.filter((schoolId) => !schoolIdsWhereExisting.includes(schoolId));
-		const createPromises = schoolIdsWhereNotExisting.map((schoolId) => this.createSchoolExternalTool(toolId, schoolId));
-		await Promise.all(createPromises);
+		const existingSchoolExternalTools = await this.schoolExternalToolRepo.findByExternalToolId(toolId);
+		const schoolIdsWhereExisting = new Set(existingSchoolExternalTools.map((tool) => tool.schoolId));
+		const schoolIdsWhereNotExisting = allSchoolIds.filter((schoolId) => !schoolIdsWhereExisting.has(schoolId));
+		const toolsToAdd = schoolIdsWhereNotExisting.map((schoolId) => this.createSchoolExternalTool(toolId, schoolId));
+		await this.schoolExternalToolRepo.saveMany(toolsToAdd);
 	}
 
-	private createSchoolExternalTool(toolId: EntityId, schoolId: EntityId): Promise<SchoolExternalTool> {
-		const schoolExternalTool = new SchoolExternalTool({
+	private createSchoolExternalTool(toolId: EntityId, schoolId: EntityId): SchoolExternalTool {
+		return new SchoolExternalTool({
 			id: new ObjectId().toHexString(),
 			toolId,
 			schoolId,
 			parameters: [],
 			isDeactivated: false,
 		});
-
-		return this.schoolExternalToolRepo.save(schoolExternalTool);
 	}
 }