BC-11143 - validate account during registration completion (#6016)

Author: Metauriel

apps/server/src/modules/registration/domain/service/registration.service.spec.ts

@@ -29,6 +29,7 @@ describe('RegistrationService', () => {
 	let userService: DeepMocked<UserService>;
 	let mailService: DeepMocked<MailService>;
 	let logger: DeepMocked<Logger>;
+	let accountService: DeepMocked<AccountService>;
 
 	beforeAll(async () => {
 		module = await Test.createTestingModule({
@@ -77,6 +78,7 @@ describe('RegistrationService', () => {
 		schoolService = module.get(SchoolService);
 		mailService = module.get(MailService);
 		logger = module.get(Logger);
+		accountService = module.get(AccountService);
 	});
 
 	afterAll(async () => {
@@ -317,6 +319,11 @@ describe('RegistrationService', () => {
 			const registration = registrationFactory.build();
 			registrationRepo.findBySecret.mockResolvedValue(registration);
 
+			userService.save.mockImplementation((user) => {
+				user.id = new ObjectId().toHexString();
+				return Promise.resolve(user);
+			});
+
 			await service.completeRegistration(registration, LanguageType.EN, 'SecurePassword123!');
 
 			expect(userService.save).toHaveBeenCalledWith(
@@ -326,6 +333,13 @@ describe('RegistrationService', () => {
 					lastName: registration.lastName,
 				})
 			);
+
+			expect(accountService.saveWithValidation).toHaveBeenCalledWith(
+				expect.objectContaining({
+					username: registration.email,
+					password: 'SecurePassword123!',
+				})
+			);
 		});
 
 		describe('when external person role is missing', () => {

apps/server/src/modules/registration/domain/service/registration.service.ts

@@ -47,7 +47,7 @@ export class RegistrationService {
 		const userDo = await this.createUser(registration, language);
 		const user = await this.userService.save(userDo);
 		const account = this.createAccount(user, password);
-		await this.accountService.save(account);
+		await this.accountService.saveWithValidation(account);
 
 		if (user.id === undefined) {
 			throw new InternalServerErrorException('User ID is undefined after saving user.');