Skip to content

Commit dcc3e33

Browse files
authored
Revert "BC-10826 - Reimplement teacher lastnames into classes administration" (#5974)
Due to Firealert BC-11023 This reverts commit 62838f7.
1 parent e4d6579 commit dcc3e33

File tree

5 files changed

+1374
-69
lines changed

5 files changed

+1374
-69
lines changed

apps/server/src/modules/group/controller/api-test/group.api.spec.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ describe('Group (API)', () => {
4949
const school = schoolEntityFactory.buildWithId({ currentYear: schoolYear });
5050
const { adminAccount, adminUser } = UserAndAccountTestFactory.buildAdmin({ school });
5151

52-
const groupSubstitutionTeacherRole = roleFactory.buildWithId({ name: RoleName.GROUPSUBSTITUTIONTEACHER });
5352
const teacherRole = roleFactory.buildWithId({ name: RoleName.TEACHER });
5453
const studentRole = roleFactory.buildWithId({ name: RoleName.STUDENT });
5554
const teacherUser = userFactory.buildWithId({ school, roles: [teacherRole] });
@@ -82,7 +81,6 @@ describe('Group (API)', () => {
8281
school,
8382
adminAccount,
8483
adminUser,
85-
groupSubstitutionTeacherRole,
8684
teacherRole,
8785
studentRole,
8886
teacherUser,
@@ -109,7 +107,7 @@ describe('Group (API)', () => {
109107
};
110108

111109
it('should return the classes of his school', async () => {
112-
const { adminClient, group, classEntity, system, schoolYear, course, adminUser, teacherUser } = await setup();
110+
const { adminClient, group, classEntity, system, schoolYear, course } = await setup();
113111

114112
const response = await adminClient.get(`/class`).query({
115113
skip: 0,
@@ -126,15 +124,15 @@ describe('Group (API)', () => {
126124
type: ClassRootType.GROUP,
127125
name: group.name,
128126
externalSourceName: system.displayName,
129-
teacherNames: [adminUser.lastName],
127+
teacherNames: [],
130128
studentCount: 0,
131129
synchronizedCourses: [{ id: course.id, name: course.name }],
132130
},
133131
{
134132
id: classEntity.id,
135133
type: ClassRootType.CLASS,
136134
name: classEntity.gradeLevel ? `${classEntity.gradeLevel}${classEntity.name}` : classEntity.name,
137-
teacherNames: [teacherUser.lastName],
135+
teacherNames: [],
138136
schoolYear: schoolYear.name,
139137
isUpgradable: false,
140138
studentCount: 0,

0 commit comments

Comments
 (0)