alternative to fix issue

Author: Loki-Afro

scripts/testing/globalSetup.ts

@@ -1,6 +1,5 @@
 
 import { RedisMemoryServer } from 'redis-memory-server';
-import { Client } from 'minio';
 
 export default async function globalSetup(): Promise<void> {
 	const redisMemoryServer = new RedisMemoryServer();
@@ -10,21 +9,5 @@ export default async function globalSetup(): Promise<void> {
 	process.env.REDIS_URL = `redis://${host}:${port}`;
 	// @ts-ignore
 	global.__REDISINSTANCE = redisMemoryServer;
-
-	const minioClient = new Client({
-		endPoint: 'localhost',
-		port: 9000,
-		useSSL: false,
-		accessKey: 'miniouser',
-		secretKey: 'miniouser',
-	});
-
-	const bucketName = 'test-bucket';
-	process.env.S3_BUCKET = bucketName;
-
-	const bucketExists = await minioClient.bucketExists(bucketName);
-	if (!bucketExists) {
-		await minioClient.makeBucket(bucketName);
-	}
 }
 

src/infra/storage/storage.service.spec.ts

@@ -41,7 +41,60 @@ describe('StorageService', () => {
 		jest.resetAllMocks();
 	});
 
-	
+	describe('onModuleInit', () => {
+		describe('when makeBucket resolves', () => {
+			it('should call makeBucket', async () => {
+				await service.onModuleInit();
+
+				expect(client.makeBucket).toHaveBeenCalledWith(bucketName);
+			});
+		});
+
+		describe('when makeBucket rejects with BucketAlreadyOwnedByYou', () => {
+			const setup = () => {
+				const error = new Error();
+				// @ts-ignore
+				error.code = 'BucketAlreadyOwnedByYou';
+				client.makeBucket.mockRejectedValueOnce(error);
+			};
+
+			it('should not throw an error', async () => {
+				setup();
+
+				await expect(service.onModuleInit()).resolves.not.toThrow();
+			});
+		});
+
+		describe('when makeBucket rejects with BucketAlreadyExists', () => {
+			const setup = () => {
+				const error = new Error();
+				// @ts-ignore
+				error.code = 'BucketAlreadyExists';
+				client.makeBucket.mockRejectedValueOnce(error);
+			};
+
+			it('should not throw an error', async () => {
+				setup();
+
+				await expect(service.onModuleInit()).resolves.not.toThrow();
+			});
+		});
+
+		describe('when makeBucket rejects with other error', () => {
+			const setup = () => {
+				const error = new Error('other error');
+				client.makeBucket.mockRejectedValueOnce(error);
+
+				return { error };
+			};
+
+			it('should throw an error', async () => {
+				const { error } = setup();
+
+				await expect(service.onModuleInit()).rejects.toThrow(error);
+			});
+		});
+	});
 
 	describe('persistDoc', () => {
 		describe('when putObject resolves', () => {

src/infra/storage/storage.service.ts

@@ -29,10 +29,18 @@ export class StorageService implements DocumentStorage, OnModuleInit {
 	}
 
 	public async onModuleInit(): Promise<void> {
-		const bucketExists = await this.client.bucketExists(this.config.S3_BUCKET);
-
-		if (!bucketExists) {
+		try {
 			await this.client.makeBucket(this.config.S3_BUCKET);
+		} catch (err: unknown) {
+			if (
+				err &&
+				typeof err === 'object' &&
+				'code' in err &&
+				(err.code === 'BucketAlreadyOwnedByYou' || err.code === 'BucketAlreadyExists')
+			) {
+				return;
+			}
+			throw err;
 		}
 	}