Use close codes everywhere

Author: dyedwiper

src/infra/authorization/authorization.service.spec.ts

@@ -1,6 +1,7 @@
 import { createMock, DeepMocked } from '@golevelup/ts-jest';
 import { Test, TestingModule } from '@nestjs/testing';
 import { HttpRequest } from 'uWebSockets.js';
+import { WebSocketCloseCode } from '../../shared/type/websocket-close-code.js';
 import { Logger } from '../logger/index.js';
 import { AuthorizationApi, AuthorizedReponse } from './authorization-api-client/index.js';
 import { AuthorizationService } from './authorization.service.js';
@@ -82,7 +83,7 @@ describe(AuthorizationService.name, () => {
 
 				const expectedResult = {
 					error: {
-						code: 4401,
+						code: WebSocketCloseCode.Unauthorized,
 						reason: 'Unauthorized',
 					},
 					hasWriteAccess: false,
@@ -108,7 +109,7 @@ describe(AuthorizationService.name, () => {
 
 				const expectedResult = {
 					error: {
-						code: 4500,
+						code: WebSocketCloseCode.InternalError,
 						reason: 'RoomId not found',
 					},
 					hasWriteAccess: false,
@@ -133,7 +134,7 @@ describe(AuthorizationService.name, () => {
 				const { req } = setupRequest('roomId', 'other=ABC');
 				const expectedResult = {
 					error: {
-						code: 4401,
+						code: WebSocketCloseCode.Unauthorized,
 						reason: 'JWT not found',
 					},
 					hasWriteAccess: false,
@@ -162,7 +163,7 @@ describe(AuthorizationService.name, () => {
 
 				const expectedResult = {
 					error: {
-						code: 4500,
+						code: WebSocketCloseCode.InternalError,
 						reason: 'testError',
 					},
 					hasWriteAccess: false,

src/infra/authorization/authorization.service.ts

@@ -1,5 +1,6 @@
 import { Injectable } from '@nestjs/common';
 import { HttpRequest } from 'uWebSockets.js';
+import { WebSocketCloseCode } from '../../shared/type/websocket-close-code.js';
 import { Logger } from '../logger/index.js';
 import {
 	AuthorizationApi,
@@ -29,9 +30,9 @@ export class AuthorizationService {
 			response = await this.fetchAuthorization(room, token);
 		} catch (error) {
 			if (error.message === 'JWT not found') {
-				response = this.createErrorResponsePayload(4401, 'JWT not found');
+				response = this.createErrorResponsePayload(WebSocketCloseCode.Unauthorized, 'JWT not found');
 			} else {
-				response = this.createErrorResponsePayload(4500, error.message);
+				response = this.createErrorResponsePayload(WebSocketCloseCode.InternalError, error.message);
 			}
 		}
 
@@ -84,7 +85,7 @@ export class AuthorizationService {
 
 		const { isAuthorized, userId } = response;
 		if (!isAuthorized) {
-			return this.createErrorResponsePayload(4401, 'Unauthorized');
+			return this.createErrorResponsePayload(WebSocketCloseCode.Unauthorized, 'Unauthorized');
 		}
 
 		return this.createResponsePayload(room, userId);

src/modules/server/api/test/websocket.api.spec.ts

@@ -8,6 +8,7 @@ import { WebsocketProvider } from 'y-websocket';
 import { Doc, encodeStateAsUpdateV2 } from 'yjs';
 import { ResponsePayloadBuilder } from '../../../../infra//authorization/response.builder.js';
 import { AuthorizationService } from '../../../../infra/authorization/index.js';
+import { WebSocketCloseCode } from '../../../../shared/type/websocket-close-code.js';
 import { ServerModule } from '../../server.module.js';
 import { TldrawServerConfig } from '../../tldraw-server.config.js';
 
@@ -184,7 +185,7 @@ describe('Websocket Api Test', () => {
 				const randomString = Math.random().toString(36).substring(7);
 				const room = randomString;
 
-				const errorResponse = ResponsePayloadBuilder.buildWithError(4401, 'Unauthorized');
+				const errorResponse = ResponsePayloadBuilder.buildWithError(WebSocketCloseCode.Unauthorized, 'Unauthorized');
 				authorizationService.hasPermission.mockResolvedValueOnce(errorResponse);
 
 				const { ydoc: client1Doc, provider } = createWsClient(room);
@@ -209,7 +210,7 @@ describe('Websocket Api Test', () => {
 				// @ts-ignore
 				expect(error.reason).toBe('Unauthorized');
 				// @ts-ignore
-				expect(error.code).toBe(4401);
+				expect(error.code).toBe(WebSocketCloseCode.Unauthorized);
 
 				provider.awareness.destroy();
 				provider.destroy();
@@ -246,7 +247,7 @@ describe('Websocket Api Test', () => {
 				// @ts-ignore
 				expect(error.reason).toBe('Missing room or userid');
 				// @ts-ignore
-				expect(error.code).toBe(1008);
+				expect(error.code).toBe(WebSocketCloseCode.InternalError);
 
 				provider.awareness.destroy();
 				provider.destroy();
@@ -281,7 +282,7 @@ describe('Websocket Api Test', () => {
 			// @ts-ignore
 			expect(error.reason).toBe('Internal Server Error');
 			// @ts-ignore
-			expect(error.code).toBe(1011);
+			expect(error.code).toBe(WebSocketCloseCode.InternalError);
 		});
 	});
 });