Skip to content

Commit e82ba85

Browse files
committed
Removes an unused instance variable, fixes wrong return values for probes with no runs
1 parent bbae554 commit e82ba85

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

packages/Babylonian-UI.package/BPProbeMorph.class/instance/valuesMorphFor..st

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ valuesMorphFor: trace
44
| values valuesContainer |
55
values := trace valuesForProbeId: self id.
66
values first traceHasFailedBefore ifTrue: [
7-
^ 'Error during execution: ' , trace recordedException printString].
7+
^ ('Error during execution: ' , trace recordedException printString) asMorph].
88

99
values := self filterValues: values throughSliderForTrace: trace.
10-
values ifEmpty: [^ self noValuesText].
10+
values ifEmpty: [^ self noValuesText asMorph].
1111

1212
valuesContainer := self newContainerMorph.
1313
values

packages/Babylonian-UI.package/BPProbeMorph.class/methodProperties.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@
1919
"setExpressionButtonClicked" : "pre 9/22/2020 10:05",
2020
"updateExpressionMorphIfNecessary" : "pre 9/22/2020 10:04",
2121
"updateFrom:" : "pre 10/12/2020 17:28",
22-
"valueMorphFor:" : "pre 10/12/2020 17:29",
23-
"valuesMorphFor:" : "pre 10/12/2020 17:28" } }
22+
"valueMorphFor:" : "pre 10/12/2020 17:39",
23+
"valuesMorphFor:" : "pre 10/12/2020 17:37" } }

packages/Babylonian-UI.package/BPTraceBasedMorph.class/properties.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"allTracesCompleted",
1111
"tracesMorph",
1212
"widgetsMorph",
13-
"sliderForFiltering",
1413
"slidersForFiltering" ],
1514
"name" : "BPTraceBasedMorph",
1615
"pools" : [

0 commit comments

Comments
 (0)