Adds concurrency protection to BPTrace to prevent nasty issues. Currently very conservative and broad. Might slow down tracing somewhat.

Author: codeZeilen

packages/Babylonian-Core.package/BPTrace.class/instance/addTracedValue.forAssertion..st

@@ -1,5 +1,6 @@
 private
 addTracedValue: aTraceValue forAssertion: anAssertionId
 
-	(self assertions at: anAssertionId ifAbsentPut: [OrderedCollection new]) add: aTraceValue.
+	mutex critical: [
+		(self assertions at: anAssertionId ifAbsentPut: [OrderedCollection new]) add: aTraceValue].
 	self addChronologicalPositionTo: aTraceValue forAnnotation: anAssertionId.

packages/Babylonian-Core.package/BPTrace.class/instance/addTracedValue.forProbe..st

@@ -1,5 +1,6 @@
 private
 addTracedValue: aTraceValue forProbe: aProbeId
 
-	(self probes at: aProbeId ifAbsentPut: [OrderedCollection new]) add: aTraceValue.
+	mutex critical: [
+		(self probes at: aProbeId ifAbsentPut: [OrderedCollection new]) add: aTraceValue].
 	self addChronologicalPositionTo: aTraceValue forAnnotation: aProbeId.

packages/Babylonian-Core.package/BPTrace.class/instance/includesValuesForProbeId..st

@@ -1,4 +1,4 @@
 testing
 includesValuesForProbeId: aProbeId
 
-	^ (self probes at: aProbeId ifAbsent: [#()]) notEmpty
+	^ mutex critical: [(self probes at: aProbeId ifAbsent: [#()]) notEmpty]

packages/Babylonian-Core.package/BPTrace.class/instance/initialize.st

@@ -7,4 +7,5 @@ initialize
 	exampleErrored := false.
 	hasTraceCompleted := false.
 	blockRecord := Dictionary new.
-	chronologicallyTrackedTraceValuesCount := 0.
+	chronologicallyTrackedTraceValuesCount := 0.
+	mutex := Mutex new.

packages/Babylonian-Core.package/BPTrace.class/instance/resultsForAssertionId..st

@@ -1,4 +1,4 @@
 accessing
 resultsForAssertionId: anAssertionId
 
-	^ self assertions at: anAssertionId ifAbsent: [#()]
+	^ mutex critical: [self assertions at: anAssertionId ifAbsent: [#()]]

packages/Babylonian-Core.package/BPTrace.class/instance/runsForBlockId..st

@@ -1,4 +1,4 @@
 accessing
 runsForBlockId: aBlockId
 
-	^ blockRecord at: aBlockId ifAbsent: [#()]
+	^ mutex critical: [blockRecord at: aBlockId ifAbsent: [#()]]

packages/Babylonian-Core.package/BPTrace.class/instance/traceBlock.enteredInContext..st

@@ -1,4 +1,7 @@
 recording
 traceBlock: id enteredInContext: aContext
 
-	(blockRecord at: id ifAbsentPut: [OrderedCollection new]) add: (self newTracedValue: nil expression: '' stackFrom: aContext).
+	| value |
+	value := self newTracedValue: nil expression: '' stackFrom: aContext.
+	mutex critical: [
+		(blockRecord at: id ifAbsentPut: [OrderedCollection new]) add: value].

packages/Babylonian-Core.package/BPTrace.class/instance/traceValues.st

@@ -3,8 +3,9 @@ traceValues
 
 	"Reduce does not work for empty collections, so we have to add an extra conditional"
 	| probesAndAssertions |
-	probesAndAssertions := self probes asCollection.
-	probesAndAssertions addAll: self assertions asCollection.
+	mutex critical: [
+		probesAndAssertions := self probes asCollection.
+		probesAndAssertions addAll: self assertions asCollection].
 	probesAndAssertions ifEmpty: [^ probesAndAssertions values ].
 	^ (probesAndAssertions values fold: [:a :b | a , b]) sorted: [:a | a chronologicalPosition] ascending.
 

packages/Babylonian-Core.package/BPTrace.class/instance/valuesForProbeId..st

@@ -1,7 +1,8 @@
 accessing
 valuesForProbeId: aProbeId
 
-	^ self probes at: aProbeId ifAbsent: [
-		self exampleErrored 
-			ifTrue: [{BPFailedTrace new}] 
-			ifFalse: [#()]]
+	mutex critical: [
+		^ self probes at: aProbeId ifAbsent: [
+			self exampleErrored 
+				ifTrue: [{BPFailedTrace new}] 
+				ifFalse: [#()]]]

packages/Babylonian-Core.package/BPTrace.class/methodProperties.json

@@ -3,8 +3,8 @@
 		"maxStackSize" : "jb 6/30/2021 01:13" },
 	"instance" : {
 		"addChronologicalPositionTo:forAnnotation:" : "lu 11/21/2021 18:56",
-		"addTracedValue:forAssertion:" : "lu 11/21/2021 18:47",
-		"addTracedValue:forProbe:" : "lu 11/21/2021 18:47",
+		"addTracedValue:forAssertion:" : "pre 1/11/2023 16:24",
+		"addTracedValue:forProbe:" : "pre 1/11/2023 16:25",
 		"assertions" : "pre 5/10/2019 10:09",
 		"chronologicallyTrackedTraceValuesCount" : "lu 11/22/2021 22:03",
 		"example" : "pre 5/8/2019 16:26",
@@ -15,23 +15,23 @@
 		"executionResult" : "jb 12/30/2021 21:09",
 		"hasTraceCompleted" : "pre 8/17/2020 09:55",
 		"hasTraceCompleted:" : "jb 12/7/2020 18:54",
-		"includesValuesForProbeId:" : "pre 7/24/2019 11:30",
-		"initialize" : "lu 11/21/2021 18:55",
+		"includesValuesForProbeId:" : "pre 1/11/2023 16:27",
+		"initialize" : "pre 1/11/2023 16:23",
 		"mementoFor:" : "jb 6/11/2021 00:47",
 		"newTracedAssignmentValue:previousValues:expression:stackFrom:" : "pre 10/12/2020 17:58",
 		"newTracedValue:expression:stackFrom:" : "pre 10/12/2020 17:57",
 		"probes" : "pre 5/8/2019 16:44",
 		"recordedException" : "pre 7/25/2019 12:28",
 		"recordedException:" : "jb 12/7/2020 18:54",
-		"resultsForAssertionId:" : "pre 11/18/2019 12:55",
-		"runsForBlockId:" : "pre 9/25/2020 17:08",
+		"resultsForAssertionId:" : "pre 1/11/2023 16:27",
+		"runsForBlockId:" : "pre 1/11/2023 16:26",
 		"stackFrom:" : "pre 11/29/2022 16:24",
 		"trace:forAssertion:inContext:" : "jb 12/7/2020 18:54",
 		"trace:forId:inContext:" : "jb 12/7/2020 18:54",
 		"traceAssignment:previousValues:forId:inContext:" : "jb 12/7/2020 18:54",
-		"traceBlock:enteredInContext:" : "jb 12/7/2020 18:54",
+		"traceBlock:enteredInContext:" : "pre 1/11/2023 16:25",
 		"traceException:" : "jb 12/7/2020 18:54",
 		"traceException:forId:" : "jb 12/30/2021 21:10",
 		"traceExecutionResult:" : "jb 12/30/2021 21:15",
-		"traceValues" : "lu 11/22/2021 23:20",
-		"valuesForProbeId:" : "lu 11/22/2021 23:25" } }
+		"traceValues" : "pre 1/11/2023 16:26",
+		"valuesForProbeId:" : "pre 1/11/2023 16:26" } }