Skip to content

Commit 2cd976a

Browse files
committed
Increase robustnesss of historic bench results parsing
1 parent 4830ca6 commit 2cd976a

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/TraceDebuggerBenchmarks.package/TDBBenchmarkRunner.class/class/parseHistoricBench..st

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@ parseHistoricBench: bench
88

99
benchmark privateTimeToRun: bench value milliSeconds.
1010
bench extra ifNotNil: [
11-
| extra |
11+
[| extra |
1212
extra := Json readFrom: bench extra readStream.
1313
benchmark
1414
privateTotalTime: extra totalTime milliSeconds;
1515
privatePreparationTime: extra preparationTime milliSeconds;
16-
privatePostparationTime: extra postparationTime milliSeconds].
16+
privatePostparationTime: extra postparationTime milliSeconds]
17+
ifError: [:msg | Transcript showln: msg "sigh, we pushed some invalid data in the past..."]].
1718

1819
^ benchmark

packages/TraceDebuggerBenchmarks.package/TDBBenchmarkRunner.class/methodProperties.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"historicDataUrl" : "ct 1/8/2022 22:35",
77
"historicRawData" : "ct 1/8/2022 22:41",
88
"historicTimesToRun" : "ct 1/8/2022 22:55",
9-
"parseHistoricBench:" : "ct 1/9/2022 02:00",
9+
"parseHistoricBench:" : "ct 1/9/2022 02:11",
1010
"parseHistoricRawData:" : "ct 1/9/2022 01:52",
1111
"run" : "ct 1/8/2022 15:39",
1212
"testSelector" : "ct 1/8/2022 15:38" },

0 commit comments

Comments
 (0)