properly release errcode object and skip NULL on finalize

Signed-off-by: Thomas Naughton <[email protected]>

Author: naughtont3

ompi/errhandler/errcode.c

@@ -280,7 +280,8 @@ int ompi_mpi_errcode_finalize (void)
          * we have to free.
          */
         errc = (ompi_mpi_errcode_t *)opal_pointer_array_get_item(&ompi_mpi_errcodes, i);
-        OBJ_RELEASE (errc);
+        if (NULL != errc)
+            OBJ_RELEASE (errc);
     }
 
     OBJ_DESTRUCT(&ompi_success);
@@ -448,6 +449,11 @@ int ompi_mpi_errcode_remove(int errnum)
 
     opal_mutex_unlock(&errcode_lock);
 
+    /* Release the object on success */
+    if (ret >= 0) {
+        OBJ_RELEASE(errcodep);
+    }
+
     /*
      * Return lastused value captured under lock so caller has
      * consistent value to set MPI_LASTUSEDCODE attribute.
@@ -487,6 +493,11 @@ int ompi_mpi_errclass_remove(int errclass)
 
     opal_mutex_unlock(&errcode_lock);
 
+    /* Release the object on success */
+    if (ret >= 0) {
+        OBJ_RELEASE(errcodep);
+    }
+
     /*
      * Return lastused value captured under lock so caller has
      * consistent value to set MPI_LASTUSEDCODE attribute.