CID 1659063 - fix potential memory leaks

hppritcha · hppritcha · commit f281a4e55797 · 2025-08-12T13:17:54.000-06:00
Signed-off-by: Howard Pritchard &lt;howardp@lanl.gov&gt;
diff --git a/ompi/mca/coll/han/coll_han_alltoall.c b/ompi/mca/coll/han/coll_han_alltoall.c
@@ -2,6 +2,7 @@
  * Copyright (c) 2024      Amazon.com, Inc. or its affiliates. All Rights Reserved.
  *
  * Copyright (c) 2025      Barcelona Supercomputing Center (BSC-CNS). All Rights Reserved.
+ * Copyright (c) 2025      Triad National Security, LLC. All rights
  *
  * Additional copyrights may follow
  *
@@ -136,6 +137,7 @@ int mca_coll_han_alltoall_using_smsc(
                              "han cannot handle alltoall with this communicator. Fall back on another component\n");
         /* HAN cannot work with this communicator so fallback on all collectives */
         HAN_LOAD_FALLBACK_COLLECTIVES(comm, han_module);
+        OBJ_DESTRUCT(&convertor);
         return han_module->previous_alltoall(sbuf, scount, sdtype, rbuf, rcount, rdtype,
                                           comm, han_module->previous_alltoall_module);
     }
@@ -151,6 +153,7 @@ int mca_coll_han_alltoall_using_smsc(
          * future calls will then be automatically redirected.
          */
         HAN_UNINSTALL_COLL_API(comm, han_module, alltoall);
+        OBJ_DESTRUCT(&convertor);
         return han_module->previous_alltoall(sbuf, scount, sdtype, rbuf, rcount, rdtype,
                                              comm, han_module->previous_alltoall_module);
     }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`* Copyright (c) 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.`
`3`	`3`	`*`
`4`	`4`	`* Copyright (c) 2025 Barcelona Supercomputing Center (BSC-CNS). All Rights Reserved.`
	`5`	`+ * Copyright (c) 2025 Triad National Security, LLC. All rights`
`5`	`6`	`*`
`6`	`7`	`* Additional copyrights may follow`
`7`	`8`	`*`
`@@ -136,6 +137,7 @@ int mca_coll_han_alltoall_using_smsc(`
`136`	`137`	`"han cannot handle alltoall with this communicator. Fall back on another component\n");`
`137`	`138`	`/* HAN cannot work with this communicator so fallback on all collectives */`
`138`	`139`	`HAN_LOAD_FALLBACK_COLLECTIVES(comm, han_module);`
	`140`	`+ OBJ_DESTRUCT(&convertor);`
`139`	`141`	`return han_module->previous_alltoall(sbuf, scount, sdtype, rbuf, rcount, rdtype,`
`140`	`142`	`comm, han_module->previous_alltoall_module);`
`141`	`143`	`}`
`@@ -151,6 +153,7 @@ int mca_coll_han_alltoall_using_smsc(`
`151`	`153`	`* future calls will then be automatically redirected.`
`152`	`154`	`*/`
`153`	`155`	`HAN_UNINSTALL_COLL_API(comm, han_module, alltoall);`
	`156`	`+ OBJ_DESTRUCT(&convertor);`
`154`	`157`	`return han_module->previous_alltoall(sbuf, scount, sdtype, rbuf, rcount, rdtype,`
`155`	`158`	`comm, han_module->previous_alltoall_module);`
`156`	`159`	`}`